Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential ID's for events? #817

Closed
richardhuaaa opened this issue Jan 28, 2022 · 2 comments
Closed

Sequential ID's for events? #817

richardhuaaa opened this issue Jan 28, 2022 · 2 comments

Comments

@richardhuaaa
Copy link

I wonder if it would be nice to have sequential ID's on events, so that during playback the player can detect if events are missing, out of order, or duplicated (and same within our own app layer).

I recently fixed an issue on our end where sessions weren't replaying due to missing snapshots (ultimately because payloads were failing to reach our server). However, I wonder if other cases would be harder to detect, such as events missing in the middle, or duplicate events, especially as we work on fancier things like long-lived sessions, live streaming sessions, buffering in chunks, etc.

These ID's could also be added ourselves within the app layer, I just wonder if it would have additional usefulness for debugging if it was baked into the library itself, so thought I would start a discussion.

@Yuyz0112
Copy link
Member

agree, maybe a sequential id plugin is good

@Juice10
Copy link
Contributor

Juice10 commented Feb 4, 2022

Looks like #819 solved this feature request. Thanks for that @Yuyz0112, and thank you for the feature request @Silhouettes. Closing this issue for now

@Juice10 Juice10 closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants