Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Turn on .bs.js suffix + in-source generation #36

Closed
chenglou opened this issue Feb 2, 2018 · 4 comments
Closed

Turn on .bs.js suffix + in-source generation #36

chenglou opened this issue Feb 2, 2018 · 4 comments
Milestone

Comments

@chenglou
Copy link
Contributor

chenglou commented Feb 2, 2018

Yo @rrdelaney! Can we turn on https://bucklescript.github.io/docs/en/build-configuration.html#package-specs and https://bucklescript.github.io/docs/en/build-configuration.html#suffix? It's the new default

@rrdelaney
Copy link
Owner

Sounds good to me 😁 I can probably do that this weekend

@rrdelaney rrdelaney added this to the 1.0 milestone Feb 9, 2018
@baransu
Copy link

baransu commented Mar 15, 2018

I would like to help with this. I'm using 1.0.0-alpha2 and at startup there is missing index.bs.js error. I see that package spec was updated but I cannot find BuckleScript build step. How do you recommend to implement this?

@rrdelaney
Copy link
Owner

@baransu I've been super-busy lately, and haven't had a lot of time to work on this unfortunately. The -alpha releases will most likely all be broken. If you want to help out, working on reason-webpack-plugin would be a huge help! Right now it doesn't detect changes to .re files, so adding context dependencies to the webpack plugin would be awesome 😄

@rrdelaney rrdelaney modified the milestones: 1.0, 0.9 May 3, 2018
@rrdelaney
Copy link
Owner

Done as part of v0.9.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants