Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: The strings from userconfirm.hpp cannot be translated #1868

Open
sunwire opened this issue Nov 17, 2024 · 1 comment
Open

I18N: The strings from userconfirm.hpp cannot be translated #1868

sunwire opened this issue Nov 17, 2024 · 1 comment

Comments

@sunwire
Copy link

sunwire commented Nov 17, 2024

msg = "Is this ok [Y/n]: ";
} else {
msg = "Is this ok [y/N]: ";

The strings cannot be translated even if I use the _() macro.
The cmake --build build --target gettext-potfiles command seems to ignore them.
The same with "n", "N", "y" or "Y"

userconfirm() function is used by dnf5, dnf5daemon-client and copr plugin

@sunwire
Copy link
Author

sunwire commented Nov 23, 2024

Proposed changes
main...sunwire:dnf5:i18n-yesno

PS.
I don't like the multiple uses of #define but I can't think of any other solution.

$ sudo  ./dnf5 install s-tui
Aktualizowanie i ładowanie repozytoriów:
Załadowano repozytoria.
Pakiet                                                                                  Arch.              Wersja                                                                                  Repozytorium                                        Rozmiar
Instalowanie:
 s-tui                                                                                  noarch             1.1.6-3.fc41                                                                            fedora                                            293.4 KiB
Instalowanie zależności:
 python3-urwid                                                                          noarch             2.6.14-2.fc41                                                                           fedora                                              3.2 MiB
 python3-wcwidth                                                                        noarch             0.2.13-5.fc41                                                                           fedora                                            559.8 KiB

Podsumowanie transakcji:
 Instalowanie:         3 pakietów

Całkowity rozmiar pakietów przychodzących wynosi 1 MiB. Należy pobrać 1 MiB.
Po tej operacji zostanie użyte dodatkowo 4 MiB (zainstaluj 4 MiB, usuń 0 B).
Czy to jest ok [t/N]: t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant