Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked-sender v0.17.4 fails to slice #339

Closed
vonderheide opened this issue Feb 18, 2022 · 4 comments
Closed

chunked-sender v0.17.4 fails to slice #339

vonderheide opened this issue Feb 18, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@vonderheide
Copy link

Chunked uploads started to fail after upgrading chunked-uploady from 0.17.3 to 0.17.4.
Now, each chunk fails with "chunk failure - failed to slice".

I tracked this down to sendChunks.js:64. The blob is returned correctly from getChunkDataFromFile, but the setter of chunk detects that the proxy is unmodifiable and ignores the data. This causes the next line to throw a ChunkedSendError.

0.17.3 works fine - it looks like the proxy was introduced for 0.17.4.

Let me know if I can further help with debugging.

@yoavniran
Copy link
Collaborator

thanks @vonderheide
I actually just fixed this issue and am releasing the fix now (0.17.5)
I think it only affects dev time and not production builds but nonetheless, the fix will be out shortly

@yoavniran yoavniran added the bug Something isn't working label Feb 18, 2022
@yoavniran yoavniran self-assigned this Feb 18, 2022
@vonderheide
Copy link
Author

Thanks, that was quick :-)
Yes, it looks like this will not happen if isProduction() returns true.

@yoavniran
Copy link
Collaborator

@vonderheide 0.17.5 is out now. Please let me know if fixed or if you experience issues still.

@vonderheide
Copy link
Author

Works like a charm. Thanks again for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants