Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form data ordering #103

Closed
teejteej opened this issue Nov 27, 2020 · 4 comments · Fixed by #104
Closed

Form data ordering #103

teejteej opened this issue Nov 27, 2020 · 4 comments · Fixed by #104

Comments

@teejteej
Copy link

teejteej commented Nov 27, 2020

Hi,

Some services like S3 stop reading form data once the 'file' value has been reached.
When looking at the uploady POST request, it starts with the 'file' value, and so the other values like 'key' that are needed for S3, are ignored.

Is there any way in which the order of values for the POST can be changed so that 'file' comes last?

@yoavniran
Copy link
Collaborator

I'll create a PR that adds the file after the params, so it is read last.
Dont think it should affect anyone else

Technically, you could create a custom sender that does this. (Drive-Uploady uses this capability) It would be pretty simple but its not documented so I'd advise to wait for the next minor version (I'll release shortly)

@teejteej
Copy link
Author

Excellent thanks!

@yoavniran yoavniran linked a pull request Nov 28, 2020 that will close this issue
@yoavniran
Copy link
Collaborator

@teejteej 0.8.0 is released. Hopefully it solves the issue with S3.

@teejteej
Copy link
Author

Thanks! Can confirm it fixes S3 uploading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants