Skip to content

Commit d8ee22b

Browse files
author
Richard P. Field III
committed
refactor: Propagate native component events
This commit propagates the native component events like click instead of intercepting them with Svelte and re-dispatching them.
1 parent 8cad03c commit d8ee22b

File tree

3 files changed

+3
-26
lines changed

3 files changed

+3
-26
lines changed

src/lib/button/Button.svelte

+1-8
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,17 @@
22
import type { ColorMode, FillMode, ButtonType } from '$lib/types';
33
44
import { COLOR_MODE, FILL_MODE, BUTTON_TYPE } from '$lib/types';
5-
import { createEventDispatcher } from 'svelte';
65
76
export let type: ButtonType = BUTTON_TYPE.BUTTON;
87
export let color: ColorMode;
98
export let fill: FillMode;
109
export let disabled = false;
11-
12-
const dispatch = createEventDispatcher();
13-
14-
function dispatchEvent(event: Event) {
15-
dispatch(event.type);
16-
}
1710
</script>
1811

1912
<button
2013
{disabled}
2114
type={type === BUTTON_TYPE.SUBMIT ? 'submit' : 'button'}
22-
on:click={dispatchEvent}
15+
on:click
2316
class="w-full rounded-md border px-4 py-2 focus:outline-none"
2417
class:bg-transparent={fill === FILL_MODE.RING}
2518
class:bg-spek-primary-600={fill === FILL_MODE.FILL && color === COLOR_MODE.PRIMARY}

src/lib/datepicker/Datepicker.svelte

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,12 @@
11
<script lang="ts">
2-
import { createEventDispatcher } from 'svelte';
3-
42
export let value: string;
53
export let name = '';
6-
7-
const dispatch = createEventDispatcher();
8-
9-
function dispatchEvent(event: Event) {
10-
dispatch(event.type);
11-
}
124
</script>
135

146
<input
157
{name}
168
type="date"
179
bind:value
18-
on:change={dispatchEvent}
10+
on:change
1911
class="w-full rounded border bg-spek-facade-50 p-1 text-sm outline-none outline-offset-0 focus:outline-spek-primary-400 dark:border-transparent dark:bg-spek-facade-500"
2012
/>

src/lib/textbox/Textbox.svelte

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,12 @@
11
<script lang="ts">
2-
import { createEventDispatcher } from 'svelte';
3-
42
export let value: string;
53
export let name = '';
6-
7-
const dispatch = createEventDispatcher();
8-
9-
function dispatchEvent(event: Event) {
10-
dispatch(event.type);
11-
}
124
</script>
135

146
<input
157
{name}
168
type="text"
179
bind:value
18-
on:change={dispatchEvent}
10+
on:change
1911
class="w-full rounded border bg-spek-facade-50 p-1 text-sm outline-none outline-offset-0 focus:outline-spek-primary-400 dark:border-transparent dark:bg-spek-facade-500"
2012
/>

0 commit comments

Comments
 (0)