Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routify V3] <div id="..."> wrappers created for every part of the route, even though they are not part of any page or module #497

Open
divStar opened this issue Dec 19, 2022 · 2 comments
Labels
bug Something isn't working needs triage

Comments

@divStar
Copy link

divStar commented Dec 19, 2022

bug description
<div id="...">...</div>wrappers are created for every part of the route even though I wouldn't expect them since they are not defined in any page or _module component nor in any of the regular components.
I am not sure if it was like that from the beginning, but my CSS, that seemed to work with version 3.0.0-next.123 (and possibly 3.0.0-next.129), stopped doing so.

What bothers me, is, that given e.g. the following route: /calendar/2022-09-01 I get divs, that are not defined in any of the following:

  1. not in the root /routes/_module.svelte
  2. not in the /routes/calendar/_module.svelte
  3. not in the /routes/calendar/[date]/index.svelte

As the first screenshot shows, I have useless and bothering div containers around the actual useful container (the one with class="main calendar-page") and I do not know how to get rid of them.

Is that expected behavior, did I miss something or is it a bug that needs fixing?

package.json
Just standard npm run dev.

version
Routify 3 (Version next, currently 3.0.0-next.137).

screenshot
Screenshot of the month calendar page
Screenshot of the month calendar page

Login page screenshot
Login page (in routes/login.svelte)

I can provide more information about the set up if need be, though apart of routify, some UI framework (attractions) and a couple of libraries as well as Vite (and Vitest) I am not using anything worth mentioning. I think, that routify just creates div containers in one another for every part of the route.

Edit: since I can mostly work around this with proper CSS selectors, it does not bother me that much. I just wonder if it is supposed to be like this, if I have messed up somewhere or if it's a (probably low) bug.

@divStar divStar added bug Something isn't working needs triage labels Dec 19, 2022
@jakobrosenberg
Copy link
Member

Thanks for the feedbcak @divStar

The div wrappers are work in progress. It's one of the last things that need to be solved before going to rc.

They're required for certain features of Routify, but it should be possible to remove them in the near future.

@divStar
Copy link
Author

divStar commented Dec 25, 2022

Thank you for your response. I'll wait then I guess. Close this issue if you decide so. I'll work around for the time being by accounting for it if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

2 participants