toml: support inline tables in arrays #2065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax like this is valid TOML:
but currently it gets incorrectly rejected by Rouge:
I believe this change fixes that without introducing any obvious side-effects.
As a side-note: since 1bdd948, I think the special case for
ident = {in :basic is probably no longer necessary, but I'm not confident enough in that to actually remove it right now. I also think having theident =case in :content is incorrect, and that should be in :inline instead (or in some mixin that can be shared by :root and :inline) – currently, things likex = [ y = 2 ]are accepted despite being invalid TOML, and I believe that rule is the reason for that.