You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following fixes will need to be implemented to get sheldon working on windows, not sure if there's anything else. I'm happy to accept PRs for any of these changes.
The fmutex dependency does not support windows, we will need to use something like LockFileEx on windows, this could be added either in fmutex or in sheldon I don't mind.
lock_and_source_clean_permission_denied test currently uses use std::os::unix::fs::PermissionsExt;, we will probably need an equivalent test on windows and only enable this test on unix.
CI will need to be updated to test and release binaries for targets x86_64-pc-windows-msvc and aarch64-pc-windows-msvc
@rossmacarthur What do you think about the fs2 crate and its lock exclusive functions? https://docs.rs/fs2/latest/fs2/trait.FileExt.html if these are sufficient then it would be simple to just swap out fmutex with fs2 and it should compile (minus the test cases obviously) onWindows successfully.
Is there any chance to get Sheldon binaries for Windows arm64 a/o amd64? I would be more then happy to test the packages.
The text was updated successfully, but these errors were encountered: