Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #167

Open
CrystalMethod opened this issue Nov 23, 2023 · 2 comments
Open

Support Windows #167

CrystalMethod opened this issue Nov 23, 2023 · 2 comments
Labels
feature New feature or request

Comments

@CrystalMethod
Copy link

Is there any chance to get Sheldon binaries for Windows arm64 a/o amd64? I would be more then happy to test the packages.

@rossmacarthur rossmacarthur changed the title Windows support? Support Windows Nov 25, 2023
@rossmacarthur rossmacarthur added the feature New feature or request label Nov 25, 2023
@rossmacarthur
Copy link
Owner

rossmacarthur commented Nov 25, 2023

The following fixes will need to be implemented to get sheldon working on windows, not sure if there's anything else. I'm happy to accept PRs for any of these changes.

  • The fmutex dependency does not support windows, we will need to use something like LockFileEx on windows, this could be added either in fmutex or in sheldon I don't mind.
  • lock_and_source_clean_permission_denied test currently uses use std::os::unix::fs::PermissionsExt;, we will probably need an equivalent test on windows and only enable this test on unix.
  • CI will need to be updated to test and release binaries for targets x86_64-pc-windows-msvc and aarch64-pc-windows-msvc

@kvnxiao
Copy link

kvnxiao commented Dec 13, 2023

@rossmacarthur What do you think about the fs2 crate and its lock exclusive functions? https://docs.rs/fs2/latest/fs2/trait.FileExt.html if these are sufficient then it would be simple to just swap out fmutex with fs2 and it should compile (minus the test cases obviously) onWindows successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants