[Feature Request] Expand user config to also deal with user specified style (bold / italics) setting

[janislaus]

Hi,
great theme. It would be great to also be able to specify the style (bold / italic) for text in the setup function.

It already works, if the given highlight group does not already have a specified style. However, if for example the following is passed to the setup function:
highlight_groups = { ['@method'] = { bg = 'rose', style = 'bold'}, ... }
Here '@method' is already in italics. The result is, that '@method' will be both italic and bold.

Desired behavior:
The style specified by the user takes precedence over the preconfigured style.

[mvllow]

I'm curious if moving to the newer highlight api would solve this, e.g:

- ['@method'] = { bg = 'rose', style = 'bold' }
+ ['@method'] = { bg = 'rose', bold = true, italic = false }

In the example above I explicitly disabled italic but I'm actually not sure if that would be necessary. Will play around with it though :)

[mvllow]

Highlight api has been updated on the canary branch. Your overrides should now replace existing highlights entirely, e.g:

require("rose-pine").setup({
  highlight_groups = {
    ["@method"] = { bg = "rose", bold = true },
  },
})

Keep in mind that for the above example, a highlight group could be both @method and @variable – meaning @variable (which is italic by default) would also need overridden.

On a side note, you could disable all italics to begin with via disable_italics = true.

[janislaus]

Thanks for the fix. The canary branch does exactly what I wanted ;)