From 243ee63ca369f0fb90397ba9ae0ca1283ab16ad3 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Tue, 4 Oct 2022 09:26:37 +0200 Subject: [PATCH] Fix parameter change event (#310) (#311) Signed-off-by: acuadros95 Signed-off-by: acuadros95 (cherry picked from commit 786d95e3f2b20c156c8a88e7ff4b693e41171125) Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> --- rclc_parameter/src/rclc_parameter/parameter_server.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/rclc_parameter/src/rclc_parameter/parameter_server.c b/rclc_parameter/src/rclc_parameter/parameter_server.c index 4cbdd646..b34ed000 100644 --- a/rclc_parameter/src/rclc_parameter/parameter_server.c +++ b/rclc_parameter/src/rclc_parameter/parameter_server.c @@ -1300,13 +1300,13 @@ rclc_parameter_set_bool( return RCLC_PARAMETER_MODIFICATION_REJECTED; } + parameter->value.bool_value = value; + if (parameter_server->notify_changed_over_dds) { rclc_parameter_prepare_changed_event(¶meter_server->event_list, parameter); rclc_parameter_service_publish_event(parameter_server); } - parameter->value.bool_value = value; - return RCL_RET_OK; } @@ -1345,13 +1345,13 @@ rclc_parameter_set_int( return RCLC_PARAMETER_MODIFICATION_REJECTED; } + parameter->value.integer_value = value; + if (parameter_server->notify_changed_over_dds) { rclc_parameter_prepare_changed_event(¶meter_server->event_list, parameter); rclc_parameter_service_publish_event(parameter_server); } - parameter->value.integer_value = value; - return RCL_RET_OK; } @@ -1390,13 +1390,13 @@ rclc_parameter_set_double( return RCLC_PARAMETER_MODIFICATION_REJECTED; } + parameter->value.double_value = value; + if (parameter_server->notify_changed_over_dds) { rclc_parameter_prepare_changed_event(¶meter_server->event_list, parameter); rclc_parameter_service_publish_event(parameter_server); } - parameter->value.double_value = value; - return RCL_RET_OK; }