Separate rosbag_storage from rosbag #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her dependencies are gone. It passes catkin_make_isolated, but I find that hard to believe. It must be getting ros headers indirectly through rosconsole.
…t before that it was too good to be true. Now fully isolated and properly breaking. I've worked through a number of items. Now stuck on AdvertiseOptions in message_instance
…ck to player.h which is the only usage if it
… it has dependencies on roscpp.
… it has dependencies on roscpp.
…ing test executables to read and write bag files
it builds fine without it, and that will simplify my scripts
dirk-thomas
added a commit
that referenced
this pull request
Oct 12, 2013
…pp_core, split rosbag storage specific stuff from client library usage (#299)
dirk-thomas
added a commit
that referenced
this pull request
Oct 12, 2013
dirk-thomas
added a commit
that referenced
this pull request
Oct 12, 2013
ghost
assigned 
|
Please update the documentation to reflect this split. It is currently nearly impossible to find the documentation for |
|
The docs now reference the new location: http://docs.ros.org/indigo/api/rosbag/html/c++/ |
|
Thanks! |
contradict
pushed a commit
to contradict/ros_comm
that referenced
this pull request
Aug 12, 2016
Fix version clash when PyQt5 is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally filled as #248 by @tfoote
rosbag_storage contains the file manipulation tools but does not depend on the communication libraries. Allowing rosbag to be used at the API level w/o compiling against the communication libraries.
rosbag_storage elements switched to console_bridge from rosconsole
This needs to be paired with: ros/roscpp_core#12