This repository was archived by the owner on May 31, 2025. It is now read-only.
Replace kdl packages with rosdep keys#206
Merged
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
@tfoote Noetic PR job came back green. I think this one will be good to go once it's retargeted at a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested these packages using a system install of
liborocos-kdl-devandpython3-pykdlon Debian Buster and Ubuntu Focal and the tests seem to pass. This PR replaces the orocos KDL ROS packages with to-be-added rosdep keys.This PR would make the
melodic-develbranch work for ROS Noetic only, it should probably be retargeted at a new branchnoetic-devel. If multiple ROS distros on the same branch is desired, then I think thepackage.xmlwould need to be upgraded to format 3 and conditional dependencies onROS_DISTROwould need to be used.See also ros/rosdistro#23841