Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqt_robot_monitor: tree does not go stale when diagnostics stop #35

Closed
ahendrix opened this issue Aug 8, 2013 · 5 comments
Closed

rqt_robot_monitor: tree does not go stale when diagnostics stop #35

ahendrix opened this issue Aug 8, 2013 · 5 comments
Assignees
Labels

Comments

@ahendrix
Copy link

ahendrix commented Aug 8, 2013

When diagnostics are no longer published, the diagnostics tree that is displayed should reflect this.

The old RX dashboard did this by graying out the dashboard panes if no diagnostics were received within 10 seconds.

You can reproduce this behavior by playing back any bag file with diagnostics data, and observing the dashboard behavior for 10-15 seconds after the bag file finishes.

@ahendrix
Copy link
Author

ahendrix commented Aug 8, 2013

This is also a problem on startup; the old robot monitor would be grayed out and display "no message received" on startup.

Old robot_monitor when stale:
robot_monitor_stale

rqt_robot_monitor when stale:
rqt_robot_monitor_stale

Old robot_monitor on startup:
robot_monitor_startup

rqt_robot_monitor on startup:
rqt_robot_monitor_startup

@ablasdel
Copy link
Contributor

ablasdel commented Aug 8, 2013

The knowledge that nothing has been received seems like rather important information. This could alert the user to a connection issues that could be serious and that they shouldn't trust the robot_monitor info anymore.

@ghost ghost assigned ablasdel Aug 9, 2013
@ablasdel
Copy link
Contributor

ablasdel commented Aug 9, 2013

This should be a rather simple addition of a timer/color change. I will look into getting this done.

@ablasdel
Copy link
Contributor

newtimoutcolor
This will be the new look when the diagnostics timeout. This color indicator will be in addition to the bottom clock indicating time since the last message was received.

@ablasdel
Copy link
Contributor

These will fix the issue on groovy/hydro. I would like someone to check my Qt logic before we merge these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants