Skip to content

Workaround for galactic build#18

Merged
emersonknapp merged 1 commit into
ros-tooling:mainfrom
wep21:fix/build-workaround-for-galactic
Nov 29, 2021
Merged

Workaround for galactic build#18
emersonknapp merged 1 commit into
ros-tooling:mainfrom
wep21:fix/build-workaround-for-galactic

Conversation

@wep21
Copy link
Copy Markdown
Contributor

@wep21 wep21 commented Nov 26, 2021

No description provided.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from a team as a code owner November 26, 2021 05:49
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Nov 26, 2021

Note: I also create a backport PR toward ament_cmake for SCRIPTS_DESTINATION.
ament/ament_cmake#364

@wep21 wep21 mentioned this pull request Nov 26, 2021
Copy link
Copy Markdown
Member

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now - I'd also be in favor of creating a separate galactic branch soon - as Rolling will be moving to Ubuntu 22.04 for Humble and who knows what changes will come with that

@emersonknapp emersonknapp merged commit 4151102 into ros-tooling:main Nov 29, 2021
@wep21 wep21 deleted the fix/build-workaround-for-galactic branch November 30, 2021 08:19
wep21 added a commit to wep21/topic_tools that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants