Skip to content

Conversation

@v4hn
Copy link
Contributor

@v4hn v4hn commented Mar 4, 2022

These were not there before the polymorphy change either,
but they become a bit more important with it.

@rhaschke

These were not there before the polymorphy change either,
but they become a bit more important with it.
@v4hn v4hn requested a review from mlautman as a code owner March 4, 2022 14:25
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me pushing this commit. Thanks anyway!

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #3078 (90fd119) into master (6f7ce13) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 90fd119 differs from pull request most recent head 85a45b4. Consider uploading reports for the commit 85a45b4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   61.70%   61.68%   -0.02%     
==========================================
  Files         374      374              
  Lines       33258    33258              
==========================================
- Hits        20520    20511       -9     
- Misses      12738    12747       +9     
Impacted Files Coverage Δ
...ctory_processing/iterative_time_parameterization.h 100.00% <ø> (ø)
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...veit/trajectory_processing/time_parameterization.h 100.00% <ø> (ø)
...eit_ros/manipulation/pick_place/src/pick_place.cpp 88.58% <0.00%> (-3.80%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.91% <0.00%> (-2.47%) ⬇️
..._interface/src/detail/constrained_goal_sampler.cpp 74.51% <0.00%> (-1.96%) ⬇️
...g_scene_interface/src/planning_scene_interface.cpp 51.10% <0.00%> (-1.09%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 66.88% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7ce13...85a45b4. Read the comment docs.

@rhaschke
Copy link
Contributor

rhaschke commented Mar 4, 2022

I will prepare a patch release over the weekend. Hence, please disregard/drop my additional commit before merging.
Background: there is a regression fix (#3076) that should be released anyway.

@rhaschke rhaschke merged commit 3ba0a07 into moveit:master Mar 4, 2022
rhaschke pushed a commit to ubi-agni/moveit that referenced this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants