From 7fb006d68f19eaf4ad069fc9c6efbe80c8137671 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Gon=C3=A7alves?= Date: Fri, 4 Oct 2024 23:40:56 +0200 Subject: [PATCH 1/2] Set success to false on parameter not found (#4704) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Francisco Gonçalves --- nav2_mppi_controller/src/parameters_handler.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nav2_mppi_controller/src/parameters_handler.cpp b/nav2_mppi_controller/src/parameters_handler.cpp index c66d5725615..4b48a2ae0aa 100644 --- a/nav2_mppi_controller/src/parameters_handler.cpp +++ b/nav2_mppi_controller/src/parameters_handler.cpp @@ -53,6 +53,7 @@ ParametersHandler::dynamicParamsCallback( { rcl_interfaces::msg::SetParametersResult result; std::lock_guard lock(parameters_change_mutex_); + bool success =true; for (auto & pre_cb : pre_callbacks_) { pre_cb(); @@ -67,6 +68,7 @@ ParametersHandler::dynamicParamsCallback( callback->second(param); } else { RCLCPP_WARN(logger_, "Parameter %s not found", param_name.c_str()); + success = false; } } @@ -74,7 +76,7 @@ ParametersHandler::dynamicParamsCallback( post_cb(); } - result.successful = true; + result.successful = success; return result; } From 07a28e5701f6331a65daadd021f339e353b2df5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Gon=C3=A7alves?= Date: Sat, 5 Oct 2024 00:05:29 +0200 Subject: [PATCH 2/2] Linting adjustment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Francisco Gonçalves --- nav2_mppi_controller/src/parameters_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nav2_mppi_controller/src/parameters_handler.cpp b/nav2_mppi_controller/src/parameters_handler.cpp index 4b48a2ae0aa..43f5359651d 100644 --- a/nav2_mppi_controller/src/parameters_handler.cpp +++ b/nav2_mppi_controller/src/parameters_handler.cpp @@ -53,7 +53,7 @@ ParametersHandler::dynamicParamsCallback( { rcl_interfaces::msg::SetParametersResult result; std::lock_guard lock(parameters_change_mutex_); - bool success =true; + bool success = true; for (auto & pre_cb : pre_callbacks_) { pre_cb();