Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce sleep in pose controller #90

Open
warp1337 opened this issue Feb 7, 2018 · 5 comments
Open

Introduce sleep in pose controller #90

warp1337 opened this issue Feb 7, 2018 · 5 comments
Labels
help wanted

Comments

@warp1337
Copy link

warp1337 commented Feb 7, 2018

The pose controller consumes 100% CPU because the controller thread does not sleep. I commented in the corresponding commit.
@nlyubova
Copy link
Member

nlyubova commented Feb 7, 2018

Thank you for reporting, do not hesitate to make a pull request

@warp1337
Copy link
Author

warp1337 commented Feb 7, 2018 •
edited
Loading

That's basically ONE line. Sorry but, forking, cloning, pushing, open pr, merge, close, remove fork, etc... That's just not justifiable for one LOC.
Maybe the author can do that @kochigami ?

@nlyubova
Copy link
Member

nlyubova commented Feb 7, 2018

@warp1337 sorry but I do not have a robot to test it

@nlyubova
Copy link
Member

nlyubova commented Feb 10, 2018 •
edited
Loading

@warp1337 luckily github allows to do a Pull Request from a browser :) with no need of fork, clone, merge, ...

@nlyubova
Copy link
Member

Help wanted to test the master on Pepper and Nao. Could somebody do it? to check this commit 2bb282b ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warp1337 @nlyubova