Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf_prefix is not resolved #36

Open
asiron opened this issue Apr 28, 2015 · 4 comments
Open

tf_prefix is not resolved #36

asiron opened this issue Apr 28, 2015 · 4 comments

Comments

@asiron
Copy link

asiron commented Apr 28, 2015

Looks like tf::TransformListener::resolve is missing on frame_ids. Is that correct ? If yes I can make a fix for that.

@vrabaud
Copy link
Contributor

vrabaud commented Apr 28, 2015

which code please ?

@asiron
Copy link
Author

asiron commented Apr 28, 2015

Oh, sorry I forgot to tell you the code. It's in naoqi_joint_states. lines 195-197

// get base_frame_id (and fix prefix if necessary)
m_privateNh.param("base_frame_id", m_baseFrameId, m_baseFrameId);
m_privateNh.param("odom_frame_id", m_odomFrameId, m_odomFrameId);

@asiron
Copy link
Author

asiron commented Apr 29, 2015

I made a fix for that, to enable muliple robots:
193cca1

@vrabaud
Copy link
Contributor

vrabaud commented Apr 29, 2015

actually, that bug would not happen with tf2 right ? Wouldn't it be simpler to switch to tf2 ? That's what the alrosbridge that got announced yesterday does.
https://github.com/ros-naoqi/alrosbridge/blob/master/src/converters/nao_joint_state.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants