From 434d30c69d9741ce6c132121419d5273ebee62bc Mon Sep 17 00:00:00 2001 From: Nikolaus Demmel Date: Sat, 27 Oct 2018 18:08:43 +0200 Subject: [PATCH 1/2] format_map is python 3.2 or later only (see also #602) --- test/test_flake8.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_flake8.py b/test/test_flake8.py index 6c8cb496d..a354df003 100644 --- a/test/test_flake8.py +++ b/test/test_flake8.py @@ -53,7 +53,7 @@ def test_flake8(): report._application.formatter.show_statistics(report._stats) print( 'flake8 reported {report.total_errors} errors' - .format_map(locals()), file=sys.stderr) + .format(**locals()), file=sys.stderr) assert not report.total_errors, \ 'flake8 reported {report.total_errors} errors'.format(**locals()) From 23588964235d7d927544a53715e8a260aa6becdf Mon Sep 17 00:00:00 2001 From: Nikolaus Demmel Date: Sat, 27 Oct 2018 18:29:12 +0200 Subject: [PATCH 2/2] Ignore new pycodestyle rule W504 Was introduced in https://github.com/PyCQA/pycodestyle/pull/502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297 --- test/test_flake8.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_flake8.py b/test/test_flake8.py index a354df003..440ca386c 100644 --- a/test/test_flake8.py +++ b/test/test_flake8.py @@ -33,6 +33,7 @@ def test_flake8(): 'F841', # ignore presence of unused variables 'I', # ignore import order related warnings 'N802', # ignore presence of upper case in function names + 'W504', # ignore line breaks after binary operator (new rule added in 2018) ], max_line_length=200, max_complexity=10,