From 47266ba1b7ba99c3894ba88ddc20e6cd56a71ace Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steven!=20Ragnar=C3=B6k?= Date: Tue, 28 Jul 2020 13:23:09 -0400 Subject: [PATCH] StephenB told me that this doesn't work but I want to see why. The latest round of testing has issues with cppcheck 2.0 which are still being worked on. We need to propagate the pin but I also saw and forgot why this was being done with an execute resource rather than a chocolatey_package resource. --- cookbooks/ros2_windows/recipes/chocolatey_installs.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cookbooks/ros2_windows/recipes/chocolatey_installs.rb b/cookbooks/ros2_windows/recipes/chocolatey_installs.rb index 2ecbbaa..3e475e6 100644 --- a/cookbooks/ros2_windows/recipes/chocolatey_installs.rb +++ b/cookbooks/ros2_windows/recipes/chocolatey_installs.rb @@ -1,5 +1,9 @@ -execute 'cppcheck' do - command 'choco install -y git cmake curl vcredist2013 vcredist140 patch cppcheck' +%w[git cmake curl vcredist2013 vcredist140 patch].each do |pkg| + chocolatey_package pkg +end + +chocolatey_package 'cppcheck' do + version '1.90' end windows_env 'PATH' do