Improve clang-tidy check #798
Conversation
- Use run-clang-tidy to run parallel jobs - Drop -export-fixes argument to allow users to specify a location
|
I'd love to help, but we're currently swamped here with customer deliverables and conference demos. It's that time of the (fiscal) year! Thanks for your work on this. |
rhaschke
force-pushed
the
clang-tidy
branch
3 times, most recently
from
586f85d to
41ee805
Compare
|
I finally found some time to finish this. Here is an example output. Note, the last commit is needed for proper links on github. |
|
This is awesome! I'm going to make a PR on my project to use this branch of ICI and test it out. |
|
Works like a charm! |
|
@mathias-luedtke we are using this, and it works well for us. Would you mind reviewing this? |
|
Closing and reopening to re-trigger CI. The failure was unrelated to this PR. |
|
This has remained stable in my team's CI and has been excellent in conjunction with this action that highlights our clang-tidy violations in our PR diffs. |
There was a problem hiding this comment.
CI is green, downstream projects are +1-ing (and longing for this change to be merged). So I'm +1-ing too. Haven't taken a deeper look though. Deferring to @mathias-luedtke
|
@mathias-luedtke Would you mind reviewing this? |
Partially fixes #796:
-export-fixesby defaultrun-clang-tidyinstead ofclang-tidyto (hopefully) better handle parallel changes to the same filesUnfortunately, this changes cmdline API, i.e. options have different names!
TODO: Handle fixes from multiple packages:
clang_tidy_argsfor-export-fixes <filename>, replace filename with some temporary filehttps://stackoverflow.com/questions/25630633/merging-yaml-config-files-recursively-with-bash
https://mikefarah.gitbook.io/yq/v/v3.x/commands/merge
There is an interesting github action, processing clang-tidy's fixes into PR comments:
https://github.com/marketplace/actions/pull-request-comments-from-clang-tidy-reports
I triggered a test build for MoveIt: moveit/moveit#3250
@EzraBrooks, do you have resources to contribute?