Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advise regarding a suitable cost function #135

Open
ManMan88 opened this issue Nov 8, 2018 · 3 comments
Open

advise regarding a suitable cost function #135

ManMan88 opened this issue Nov 8, 2018 · 3 comments

Comments

@ManMan88
Copy link
Contributor

ManMan88 commented Nov 8, 2018

First of all thank you for this great repository, really helpful.

I'm trying to calibrate a fixed camera to a robot with a target mounted on the robot, just like this example: video.
I use the FixedCircleTargetCameraReprjErrorPK with one scene (and static target), and it works fine.
However, I want to increase the accuracy of the calibration, so I want to calibrate using several scenes.

I changed the static target to a moving target, and I tried several different cost functions, but it never seems to calibrate well. What cost function would you use for the case of a static camera and several scenes of a moving target on a robot (of course, when the images are taken, the target is static)?

Furthermore, in this video, Chris notes that the middle of an ellipse in an image (of a projected circle) is not the center of the real circle. He says that this module has some cost functions that takes that into account. What cost functions are suitable for that?

Thanks a lot!

@drchrislewis
Copy link
Member

I've seen all your PRs and comments coming in. I have not had time to look at them, and I have Jury duty today. Hopefully I'll get a chance tomorrow. If you go to my fork of the rosi ical repo, you will find a branch called after_intern. Look at the new node called wrist_cal. It is a stand along node that will calibrate a camera to a robot if either the camera is on the robot or the target. There should even be a launch file example. I've got a few cleanup issues and some documentation before I do a PR.

@drchrislewis
Copy link
Member

@ManMan88 look at previous comment it was for you.

@ManMan88
Copy link
Contributor Author

ManMan88 commented Nov 9, 2018

Thanks for the quick reply, I'll try it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants