Skip to content

Conversation

@jordan-palacios
Copy link
Member

Fixes #2.

Also ros_controllers is now a metapackage that depends on all controllers.

@jordan-palacios jordan-palacios marked this pull request as ready for review February 14, 2020 11:50
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

Copy link
Contributor

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Karsten1987 Karsten1987 merged commit 805bd6f into ros-controls:master Feb 15, 2020
@jordan-palacios jordan-palacios deleted the repo_split branch February 17, 2020 08:29
v-lopez pushed a commit to pal-robotics-forks/ros2_controllers that referenced this pull request Jun 10, 2020
* use dashing rclcpp logger interface

Signed-off-by: Karsten Knese <[email protected]>

* use dashing parameter API

Signed-off-by: Karsten Knese <[email protected]>

* fixed typo on nullptr check (ros-controls#20)

Fixed a nullptr check typo causing exceptions to be thrown whenever
input command is set to 0.
Signed-off-by: Poh Zhi-Ee <[email protected]>

* remove if/else

Signed-off-by: Yutaka Kondo <[email protected]>

* update travis JOB_TYPE

Signed-off-by: Yutaka Kondo <[email protected]>

* Update joint_command_handle.cpp

Co-authored-by: Poh Zhi-Ee <[email protected]>
Co-authored-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move controllers to individual packages

3 participants