From c700c9b7ce1c20a007c25db0daeaa3c7ef01d9af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?= Date: Sun, 25 May 2025 15:36:09 +0200 Subject: [PATCH] Cleanup and grooming of CI (#343) (cherry picked from commit 3ad9ccfb31dff6193da2872627f9c27f487c4f89) --- .github/workflows/humble-binary-build.yml | 2 +- .github/workflows/humble-debian-build.yml | 6 +-- .../humble-rhel-semi-binary-build.yml | 4 +- .github/workflows/humble-source-build.yml | 2 +- .github/workflows/jazzy-binary-build.yml | 2 +- .github/workflows/jazzy-debian-build.yml | 6 +-- .../jazzy-rhel-semi-binary-build.yml | 4 +- .github/workflows/jazzy-semi-binary-build.yml | 2 +- .github/workflows/jazzy-source-build.yml | 2 +- .github/workflows/prerelease-check.yml | 39 ------------------- .github/workflows/rolling-binary-build.yml | 2 +- .github/workflows/rolling-debian-build.yml | 6 +-- .../rolling-rhel-semi-binary-build.yml | 4 +- .../workflows/rolling-semi-binary-build.yml | 2 +- .github/workflows/rolling-source-build.yml | 2 +- 15 files changed, 23 insertions(+), 62 deletions(-) delete mode 100644 .github/workflows/prerelease-check.yml diff --git a/.github/workflows/humble-binary-build.yml b/.github/workflows/humble-binary-build.yml index 7ca89b7c..8a8bd9b3 100644 --- a/.github/workflows/humble-binary-build.yml +++ b/.github/workflows/humble-binary-build.yml @@ -12,7 +12,7 @@ on: - humble schedule: # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' + - cron: '03 1 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on humble branch diff --git a/.github/workflows/humble-debian-build.yml b/.github/workflows/humble-debian-build.yml index c4673282..bda644d8 100644 --- a/.github/workflows/humble-debian-build.yml +++ b/.github/workflows/humble-debian-build.yml @@ -1,4 +1,4 @@ -name: Humble Debian Build +name: Humble - Debian Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - humble schedule: # Run every day to detect flakiness and broken dependencies - - cron: '33 2 * * *' + - cron: '33 2 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on humble branch @@ -14,7 +14,7 @@ concurrency: cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }} jobs: - debian_source_build: + debian_semi_binary_build: uses: ros-controls/ros2_control_ci/.github/workflows/reusable-debian-build.yml@master with: ros_distro: humble diff --git a/.github/workflows/humble-rhel-semi-binary-build.yml b/.github/workflows/humble-rhel-semi-binary-build.yml index fea52cb6..ea733f5c 100644 --- a/.github/workflows/humble-rhel-semi-binary-build.yml +++ b/.github/workflows/humble-rhel-semi-binary-build.yml @@ -1,4 +1,4 @@ -name: Humble RHEL Binary Build +name: Humble - RHEL Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - humble schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on humble branch diff --git a/.github/workflows/humble-source-build.yml b/.github/workflows/humble-source-build.yml index f0b23ee1..9168a7ec 100644 --- a/.github/workflows/humble-source-build.yml +++ b/.github/workflows/humble-source-build.yml @@ -6,7 +6,7 @@ on: - humble schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' jobs: source: diff --git a/.github/workflows/jazzy-binary-build.yml b/.github/workflows/jazzy-binary-build.yml index 0cb53f65..41543d0d 100644 --- a/.github/workflows/jazzy-binary-build.yml +++ b/.github/workflows/jazzy-binary-build.yml @@ -12,7 +12,7 @@ on: - jazzy schedule: # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' + - cron: '03 1 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on jazzy branch diff --git a/.github/workflows/jazzy-debian-build.yml b/.github/workflows/jazzy-debian-build.yml index 4b2e4ce1..b26453e8 100644 --- a/.github/workflows/jazzy-debian-build.yml +++ b/.github/workflows/jazzy-debian-build.yml @@ -1,4 +1,4 @@ -name: Jazzy Debian Build +name: Jazzy - Debian Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - jazzy schedule: # Run every day to detect flakiness and broken dependencies - - cron: '33 2 * * *' + - cron: '33 2 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on jazzy branch @@ -14,7 +14,7 @@ concurrency: cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }} jobs: - debian_source_build: + debian_semi_binary_build: uses: ros-controls/ros2_control_ci/.github/workflows/reusable-debian-build.yml@master with: ros_distro: jazzy diff --git a/.github/workflows/jazzy-rhel-semi-binary-build.yml b/.github/workflows/jazzy-rhel-semi-binary-build.yml index 5cf206cc..a1a99f85 100644 --- a/.github/workflows/jazzy-rhel-semi-binary-build.yml +++ b/.github/workflows/jazzy-rhel-semi-binary-build.yml @@ -1,4 +1,4 @@ -name: Jazzy RHEL Binary Build +name: Jazzy - RHEL Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - jazzy schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on jazzy branch diff --git a/.github/workflows/jazzy-semi-binary-build.yml b/.github/workflows/jazzy-semi-binary-build.yml index c87c0915..3f72698b 100644 --- a/.github/workflows/jazzy-semi-binary-build.yml +++ b/.github/workflows/jazzy-semi-binary-build.yml @@ -12,7 +12,7 @@ on: - jazzy schedule: # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' + - cron: '03 1 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on jazzy branch diff --git a/.github/workflows/jazzy-source-build.yml b/.github/workflows/jazzy-source-build.yml index 642db1ee..da01dd72 100644 --- a/.github/workflows/jazzy-source-build.yml +++ b/.github/workflows/jazzy-source-build.yml @@ -6,7 +6,7 @@ on: - jazzy schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' jobs: source: diff --git a/.github/workflows/prerelease-check.yml b/.github/workflows/prerelease-check.yml deleted file mode 100644 index 80947189..00000000 --- a/.github/workflows/prerelease-check.yml +++ /dev/null @@ -1,39 +0,0 @@ -name: Pre-Release Check - -on: - workflow_dispatch: - inputs: - ros_distro: - description: 'Chose ROS distribution' - required: true - default: 'rolling' - type: choice - options: - - foxy - - galactic - - humble - - rolling - branch: - description: 'Chose branch for distro' - required: true - default: 'master' - type: choice - options: - - foxy - - galactic - - humble - - master - -jobs: - pre_release: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - with: - ref: ${{ github.event.inputs.branch }} - - name: industrial_ci - uses: ros-industrial/industrial_ci@master - env: - ROS_DISTRO: ${{ github.event.inputs.ros_distro }} - PRERELEASE: true - BASEDIR: ${{ github.workspace }}/.work diff --git a/.github/workflows/rolling-binary-build.yml b/.github/workflows/rolling-binary-build.yml index b2196ee8..a70cd279 100644 --- a/.github/workflows/rolling-binary-build.yml +++ b/.github/workflows/rolling-binary-build.yml @@ -12,7 +12,7 @@ on: - master schedule: # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' + - cron: '03 1 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on master branch diff --git a/.github/workflows/rolling-debian-build.yml b/.github/workflows/rolling-debian-build.yml index 17153004..35ff410b 100644 --- a/.github/workflows/rolling-debian-build.yml +++ b/.github/workflows/rolling-debian-build.yml @@ -1,4 +1,4 @@ -name: Rolling Debian Build +name: Rolling - Debian Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - master schedule: # Run every day to detect flakiness and broken dependencies - - cron: '33 2 * * *' + - cron: '33 2 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on master branch @@ -14,7 +14,7 @@ concurrency: cancel-in-progress: ${{ !startsWith(github.ref, '/refs/heads') }} jobs: - debian_source_build: + debian_semi_binary_build: uses: ros-controls/ros2_control_ci/.github/workflows/reusable-debian-build.yml@master strategy: fail-fast: false diff --git a/.github/workflows/rolling-rhel-semi-binary-build.yml b/.github/workflows/rolling-rhel-semi-binary-build.yml index e550dabc..d55f2b8c 100644 --- a/.github/workflows/rolling-rhel-semi-binary-build.yml +++ b/.github/workflows/rolling-rhel-semi-binary-build.yml @@ -1,4 +1,4 @@ -name: Rolling RHEL Binary Build +name: Rolling - RHEL Semi-Binary Build on: workflow_dispatch: pull_request: @@ -6,7 +6,7 @@ on: - master schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on master branch diff --git a/.github/workflows/rolling-semi-binary-build.yml b/.github/workflows/rolling-semi-binary-build.yml index ee73f50a..12652ebb 100644 --- a/.github/workflows/rolling-semi-binary-build.yml +++ b/.github/workflows/rolling-semi-binary-build.yml @@ -12,7 +12,7 @@ on: - master schedule: # Run every morning to detect flakiness and broken dependencies - - cron: '03 1 * * *' + - cron: '03 1 * * MON-FRI' concurrency: # cancel previous runs of the same workflow, except for pushes on master branch diff --git a/.github/workflows/rolling-source-build.yml b/.github/workflows/rolling-source-build.yml index 0e3739c4..02758595 100644 --- a/.github/workflows/rolling-source-build.yml +++ b/.github/workflows/rolling-source-build.yml @@ -6,7 +6,7 @@ on: - master schedule: # Run every day to detect flakiness and broken dependencies - - cron: '03 3 * * *' + - cron: '03 3 * * MON-FRI' jobs: source: