Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roq-api] Manage unknown request status #292

Open
thraneh opened this issue Oct 17, 2022 · 1 comment
Open

[roq-api] Manage unknown request status #292

thraneh opened this issue Oct 17, 2022 · 1 comment
Labels
Milestone

Comments

@thraneh
Copy link
Contributor

thraneh commented Oct 17, 2022

There are some scenarios which will leave an order request in an unknown state.

Specifically, this was identified with Binance returning HTML when a JSON response was expected.
The request status was not changed for this scenario.

This issue is meant to deal with

  • A new enum value will be introduced to manage the unknown request status: RequestStatus::ERROR. This allows us to communicate an OrderAck back to the client so it can take appropriate action.
  • The timeout logic should be implemented by the gateways. Although this logic could be implemented by the clients, it feels more natural to centralise the monitoring.
@thraneh
Copy link
Contributor Author

thraneh commented Nov 11, 2022

The underlying issue (Binance) was related to rate-limitation and lock-out and was dealt with as such.

Moving this item to roadmap for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant