Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky and linting errors on commit #28

Closed
robinduerhager opened this issue Apr 18, 2023 · 0 comments · Fixed by #29
Closed

Husky and linting errors on commit #28

robinduerhager opened this issue Apr 18, 2023 · 0 comments · Fixed by #29
Assignees
Labels
bug Something isn't working scope: all An issue that is meant for all projects

Comments

@robinduerhager
Copy link
Collaborator

There are some conflicts which have to be resolved. drilbur can't lint whysoever while ralts is able to do so. They share the same config so... idk. Somehow drilbur needs to have the no-unused-var rule set as described here: prettier/eslint-plugin-prettier#306 (comment)

Drilbur lint
grafik

Ralts lint
grafik

Also the should be passed one day ago test in tonemato-utils sometimes fails. It seems that has to do with some race condition, since between setting the date on yesterday and checking if a whole day has passed, there is so little time that it might actually fail.

@robinduerhager robinduerhager added bug Something isn't working scope: all An issue that is meant for all projects labels Apr 19, 2023
@robinduerhager robinduerhager self-assigned this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope: all An issue that is meant for all projects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant