Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with released tidyhydat and dev dbplyr #179

Closed
mgirlich opened this issue Aug 31, 2022 · 1 comment · Fixed by #186
Closed

Failure with released tidyhydat and dev dbplyr #179

mgirlich opened this issue Aug 31, 2022 · 1 comment · Fixed by #186

Comments

@mgirlich
Copy link

We see

  • checking tests ...
      Running ‘testthat.R’
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      Error in `dplyr::filter(sed_monthly_loads, !!sym_YEAR >= lubridate::year(start_date))`: Problem while computing `..1 = Year >= lubridate::year(start_date)`
      Caused by error:
      ! Object `Year` not found.
      ── Error (test_hy_sed_monthly_suscon.R:51:3): hy_sed_monthly_suscon respects Date specification ──
      Error in `dplyr::filter(sed_monthly_suscon, !!sym_YEAR >= lubridate::year(start_date))`: Problem while computing `..1 = Year >= lubridate::year(start_date)`
      Caused by error:
      ! Object `Year` not found.
      ── Error (test_hy_sed_monthly_suscon.R:64:3): functions that accept a date argument return data when specifying only the start date or end date ──
      Error in `dplyr::filter(sed_monthly_suscon, !!sym_YEAR >= lubridate::year(start_date))`: Problem while computing `..1 = Year >= lubridate::year(start_date)`
      Caused by error:
      ! Object `Year` not found.
      
      [ FAIL 8 | WARN 0 | SKIP 18 | PASS 187 ]
      Error: Test failures
      Execution halted
    

The problems comes from this change in dbplyr

  • Variables that are neither found in the data nor in the environment now
    produce an error (@mgirlich, #907).

It seems the data has the variable YEAR. As the check is case sensitive this fails.
We plan to release dbplyr soon so it would be great if you could fix this issue.

@boshek
Copy link
Collaborator

boshek commented Sep 2, 2022

👋 @mgirlich do you have any timing on this?

@boshek boshek mentioned this issue Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants