New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closeAllConnections #153

Closed

boshek opened this issue May 11, 2021 · 0 comments

Milestone

Collaborator

boshek commented May 11, 2021 •

edited

Loading

From CRAN:

These package have code calling

closeAllConnections()

which seems a very bad idea in package code, as indeed it will close all user connections etc, and not just the ones opened by the package.

Can you please fix "as necessary", and ensure your package code only closes connections it also opened?

Please fix before 2021-06-08 to safely retain your package on CRAN.

Fix here:

tidyhydat/R/download.R

Line 42 in 2c177ae

on.exit(closeAllConnections())

boshek added this to the v0.5.3 milestone

boshek closed this as completed in

3c91a47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment