Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version > CRAN take two #102

Closed
16 of 21 tasks
jooolia opened this issue May 19, 2020 · 11 comments
Closed
16 of 21 tasks

New version > CRAN take two #102

jooolia opened this issue May 19, 2020 · 11 comments
Labels

Comments

@jooolia
Copy link
Member

jooolia commented May 19, 2020

We were working towards a new version on CRAN in #71 but were waylaid by many of the NCBI functions that were no longer properly working. We will close #71 and prepare for a new release in this issue. So completeness I have kept the same list as in #71 even though I think several of the items are already complete.

From r-lib/usethis#338

Prepare for release:

#> Package which is only available in source form, and may need
#> These will not be installed
#> compilation of C/C++/Fortran: 'data.table'

Perform release:

Wait for CRAN...

  • Tag release
  • Merge RC back to master branch ( merging dev into master before submitting to CRAN)
  • Bump dev version
  • Write blog post
  • Tweet
  • Add link to blog post in pkgdown news menu

Template from r-lib/usethis#338

@sinarueeger
Copy link
Contributor

@jooolia shall we go ahead with

  1. merging this into the master first (let Scott review) and
  2. submitting to CRAN

?

jooolia added a commit that referenced this issue Jun 27, 2020
@jooolia
Copy link
Member Author

jooolia commented Jul 7, 2020

Hi @sinarueeger,
Yes sounds good. I guess we should also fix the version in the description to match what is in NEWS.md? I will do that right now.

@sinarueeger
Copy link
Contributor

Hi Julia! Forgot about the version number... thanks for fixing that (just approved the PR).

@jooolia
Copy link
Member Author

jooolia commented Jul 14, 2020

Just ran devtools::check_win_devel() again and now there is a new WARNING:
https://win-builder.r-project.org/iUiM5i0dzCRa/00check.log
checking re-building of vignette outputs ... [0s] WARNING
Error(s) in re-building vignettes:
--- re-building 'rsnps_vignette.Rmd' using knitr
Error: processing vignette 'rsnps_vignette.Rmd' failed with diagnostics:
The 'markdown' package should be declared as a dependency of the 'rsnps' package (e.g., in the 'Suggests' field of DESCRIPTION), because it contains vignette(s) built with the 'markdown' package. Please see yihui/knitr#1864 for more information.
--- failed re-building 'rsnps_vignette.Rmd'

SUMMARY: processing the following file failed:
'rsnps_vignette.Rmd'

So I will try following this advice and re-running to see if this solves this issue. If so I will open a PR.

UPDATE: Adding in {markdown} fixes the issue and now there is only 1 NOTES (about the maintainer, there is a second there because I had an uncommitted file in the package directory). https://win-builder.r-project.org/J4mZV0q1B1q2

@jooolia
Copy link
Member Author

jooolia commented Aug 31, 2020

Hi @stefaniebutland,
@sinarueeger and I have released a new version of rsnps on CRAN. We were wondering if it might be interesting to write up a short post on this update as the package was not wholly working properly (due to a change in one of the APIs) and we have now fixed it.

Thanks, Julia

@stefaniebutland
Copy link
Member

Sorry for my delay - on staycation will Sep 9 but couldn't resist coming here to say congratulations and a post sounds great.

Our Blog Guide has most of the info you should need. In this case, it sounds like a tech note might be most appropriate, unless you wanted to include more narrative. We haven't had a post about rnsps before and you did take on co-maintenance so there are opportunities to tell a story.

Let me know when you'd like to submit a draft and I can suggest a publication date.

@jooolia
Copy link
Member Author

jooolia commented Sep 8, 2020

Thanks a lot @stefaniebutland! We will mull it over and get back to you. :)

@stefaniebutland
Copy link
Member

@jooolia @sinarueeger thoughts on tech note vs blog post and when you might want to submit a draft? (no pressure)

@jooolia
Copy link
Member Author

jooolia commented Sep 17, 2020

Hi @stefaniebutland thanks for following up. We will meet and discuss this a bit next week. Then we can let you know what we're thinking. :)

@stefaniebutland
Copy link
Member

@jooolia have you made a decision about post or tech note? You can suggest a date for draft submission and based on that I'll propose a publication date.

@jooolia
Copy link
Member Author

jooolia commented Oct 7, 2020

Thanks @stefaniebutland for following up. We will write a blog post when we will propose some new features.

@jooolia jooolia closed this as completed Oct 7, 2020
@jooolia jooolia unpinned this issue Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants