-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version > CRAN take two #102
Comments
@jooolia shall we go ahead with
? |
Hi @sinarueeger, |
Hi Julia! Forgot about the version number... thanks for fixing that (just approved the PR). |
Just ran SUMMARY: processing the following file failed: So I will try following this advice and re-running to see if this solves this issue. If so I will open a PR. UPDATE: Adding in {markdown} fixes the issue and now there is only 1 NOTES (about the maintainer, there is a second there because I had an uncommitted file in the package directory). https://win-builder.r-project.org/J4mZV0q1B1q2 |
Hi @stefaniebutland, Thanks, Julia |
Sorry for my delay - on staycation will Sep 9 but couldn't resist coming here to say congratulations and a post sounds great. Our Blog Guide has most of the info you should need. In this case, it sounds like a tech note might be most appropriate, unless you wanted to include more narrative. We haven't had a post about rnsps before and you did take on co-maintenance so there are opportunities to tell a story. Let me know when you'd like to submit a draft and I can suggest a publication date. |
Thanks a lot @stefaniebutland! We will mull it over and get back to you. :) |
@jooolia @sinarueeger thoughts on tech note vs blog post and when you might want to submit a draft? (no pressure) |
Hi @stefaniebutland thanks for following up. We will meet and discuss this a bit next week. Then we can let you know what we're thinking. :) |
@jooolia have you made a decision about post or tech note? You can suggest a date for draft submission and based on that I'll propose a publication date. |
Thanks @stefaniebutland for following up. We will write a blog post when we will propose some new features. |
We were working towards a new version on CRAN in #71 but were waylaid by many of the NCBI functions that were no longer properly working. We will close #71 and prepare for a new release in this issue. So completeness I have kept the same list as in #71 even though I think several of the items are already complete.
From r-lib/usethis#338
Prepare for release:
devtools::check_win_devel()
1 Note: Maintainer: 'Julia Gustavsen [email protected]' seems to be ok based on
https://mailman.stat.ethz.ch/pipermail/r-devel/2014-March/068497.html
rhub::check_for_cran()
:Linux distros have the same note as above for the maintainer:
rsnps 0.3.2.9121: NOTE Platform: | Ubuntu Linux 16.04 LTS, R-release, GCC
https://builder.r-hub.io/status/rsnps_0.3.2.9121.tar.gz-e8127d069c0b4abc9657e2a1951bc3a6
rsnps 0.3.2.9121: NOTE Platform: | Fedora Linux, R-devel, clang, gfortran
https://builder.r-hub.io/status/rsnps_0.3.2.9121.tar.gz-4a669680d60c47ebb1c44d5885de7649
Windows has this error:
rsnps 0.3.2.9121: ERROR Platform: | Windows Server 2008 R2 SP1, R-devel, 32/64 bit
checking package dependencies ... ERROR
Package required but not available: 'data.table'
https://builder.r-hub.io/status/rsnps_0.3.2.9121.tar.gz-a439a712d233486da4b75e700a6bb44d
Lines 255-257:
Trying again with
rhub::check_for_cran(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always")
as {data.table} was not compiled and thus not installed.This command gave:
rsnps 0.3.2.9121: NOTE (as above about maintainer) Platform: | Windows Server 2008 R2 SP1, R-devel, 32/64 bit
https://builder.r-hub.io/status/rsnps_0.3.2.9121.tar.gz-a3cf0e4f3a314cdda42a83b1c48edb8b
revdepcheck::revdep_check(num_workers = 4, timeout = as.difftime(360,units = "mins"))
devtools::install_github("r-lib/revdepcheck")
If new failures, update
email.yml
thenrevdepcheck::revdep_email_maintainers()
-no new failuresPolish NEWS
update comments-cran.md
update codemeta.json using
codemetar::write_codemeta(".")
(from within project folder on dev branch)update LICENSE to reflect new maintainers
update COC to include only absolute not relative links
Perform release:
Create RC branch (for bigger releases)opened PR Merge release candidate dev into master before submitting to CRAN #114 to merge dev into masterdevtools::check_win_devel()
(again!)devtools::submit_cran()
devtools::release()
(for https://docs.ropensci.org/rsnps/ it is automatically done )pkgdown::build_site()
Wait for CRAN...
Merge RC back to master branch( merging dev into master before submitting to CRAN)Template from r-lib/usethis#338
The text was updated successfully, but these errors were encountered: