Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] otp_make_config("otp") does not list 'otp' options - produces same output as otp_make_config("router") #107

Closed
oweno-tfwm opened this issue Aug 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@oweno-tfwm
Copy link

oweno-tfwm commented Aug 11, 2023

Describe the bug
otp_make_config("otp") does not list 'otp' options - produces same output as otp_make_config("router")

reproduction:

if(!require('opentripplanner')) {
  install.packages('opentripplanner')
  library('opentripplanner')
}

if(!require('jsonlite')) {
  install.packages('jsonlite')
  library('jsonlite')
}
{
  print("=====")
  print("opt.json")
  print(toJSON(otp_make_config("otp"), pretty=TRUE, auto_unbox = TRUE))  
  print("=====")
  print("router.json")
  print(toJSON(otp_make_config("router"), pretty=TRUE, auto_unbox = TRUE))  
  print("=====")
  print("build.json")
  print(toJSON(otp_make_config("build"), pretty=TRUE, auto_unbox = TRUE))  
  print("======")
}

Expected behavior
should list the config options detailed here https://docs.opentripplanner.org/en/v2.3.0/Configuration/

Screenshots
If applicable, add screenshots to help explain your problem.

System

sessionInfo()
R version 4.2.2 (2022-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19044)

Matrix products: default

locale:
[1] LC_COLLATE=English_United Kingdom.utf8 LC_CTYPE=English_United Kingdom.utf8
[3] LC_MONETARY=English_United Kingdom.utf8 LC_NUMERIC=C
[5] LC_TIME=English_United Kingdom.utf8

attached base packages:
[1] stats graphics grDevices utils datasets methods base

other attached packages:
[1] jsonlite_1.8.7 opentripplanner_0.5.1

loaded via a namespace (and not attached):
[1] compiler_4.2.2 backports_1.4.1 tools_4.2.2 checkmate_2.2.0 Please paste sessionInfo() here:

Additional context
Add any other context about the problem here.

@oweno-tfwm oweno-tfwm added the bug Something isn't working label Aug 11, 2023
@mem48
Copy link
Contributor

mem48 commented Aug 14, 2023

If you want to use otp v2.3 then you need to do otp_make_config("otp", version = 2)

@mem48
Copy link
Contributor

mem48 commented Aug 14, 2023

The opentripplanner package is still mostly focused on OTP v1.5 because of the additional analysis features that are in v1.5 and were removed for v2.

@mem48
Copy link
Contributor

mem48 commented Aug 14, 2023

See https://docs.ropensci.org/opentripplanner/articles/OTPv2.html

Note OpenTripPlanner is undergoing some significant changes at the moment with features being added and removed. To avoid constant updates to the R package we are currently targeting support at v1.5 and v2.2. Other versions may work but are not officially supported.

@mem48 mem48 closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants