Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geojson_read for reading GeoJSON #136

Closed
sckott opened this issue May 9, 2018 · 3 comments
Closed

Fix geojson_read for reading GeoJSON #136

sckott opened this issue May 9, 2018 · 3 comments
Milestone

Comments

@sckott
Copy link
Collaborator

sckott commented May 9, 2018

related to #130

@sckott sckott added this to the 0.8 milestone May 9, 2018
@sckott
Copy link
Collaborator Author

sckott commented Oct 24, 2019

update like geojson_sp did to use sf instead of rgdal

@sckott
Copy link
Collaborator Author

sckott commented Oct 24, 2019

switching to sf from rgdal:

file <- system.file("examples", "california.geojson", package = "geojsonio")
microbenchmark::microbenchmark(
    rgdal = geojson_read_old(file, what = "sp"),
    sf = geojson_read(file, what = "sp"),
    times = 10
)
Unit: milliseconds
  expr       min         lq       mean     median         uq        max neval
 rgdal 255.76413 260.923712 276.812834 283.633072 284.710731 295.775478    10
    sf   5.56713   5.740746   6.458596   6.108526   6.492157   9.328748    10

microbenchmark::microbenchmark(
    rgdal = geojson_read_old(file, what = "list"),
    sf = geojson_read(file, what = "list"),
    times = 10
)
Unit: milliseconds
  expr       min        lq      mean    median        uq       max neval
 rgdal 158.28394 201.29649 456.66645 271.69931 817.77753 904.46834    10
    sf  21.62445  22.07043  25.21725  25.59184  26.97784  29.95318    10

@sckott sckott closed this as completed in 3dbd4c8 Oct 24, 2019
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant