Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility functions for logistic regression and ols #23

Open
bcjaeger opened this issue Oct 14, 2023 · 1 comment
Open

utility functions for logistic regression and ols #23

bcjaeger opened this issue Oct 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bcjaeger
Copy link
Collaborator

default methods to find linear combos of predictors in classification and regression trees

@bcjaeger bcjaeger added the enhancement New feature or request label Oct 15, 2023
@bcjaeger
Copy link
Collaborator Author

This issue could theoretically be closed, as logreg_fit and linreg_fit in utility.cpp seem to work well enough, but a few things about logreg_fit could be fleshed out more. In particular, could this function run faster if we used the L-BFGS algorithm? And, could we go one step further and use L-BFGS to run penalized regression? I don't know much about this area other than it appears there are libraries for it in C++ and they may work with armadillo.

@ciaran-evans, would you be interested in seeing if it would be feasible to write a logistic regression function using L-BFGS that runs faster than the one in aorsf? The new function could just be a stand alone .cpp file at first and we could work through pulling it into aorsf later. No pressure...this is a loosely defined problem, and it's perfectly alright if you would like to work on a different thing. One potential pro is that this is not time-sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant