Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Controller 2.1.0 #2025

Merged
merged 7 commits into from
Aug 21, 2018
Merged

Upgrade to Controller 2.1.0 #2025

merged 7 commits into from
Aug 21, 2018

Conversation

darrenjacoby
Copy link

No description provided.

@kaisermann
Copy link
Contributor

I think you forgot to change the version in the composer.json 😃

@darrenjacoby
Copy link
Author

@kaisermann haha yea, updated the fork now

@sagalbot
Copy link

sagalbot commented Feb 14, 2018

Was there a reason that PascalCase wasn't used for the autoloaded files/folders as described in PSR-4 before this PR?

@darrenjacoby
Copy link
Author

@sagalbot nope

@runofthemill
Copy link

@retlehs the book will need updates in /chapters/04-customizing-templates/blade-templates.html =D

@darrenjacoby maybe consider adding a note in the https://github.com/soberwp/controller readme for anyone updating from 9.0.0-beta.4? took me a little bit to sort it out and I could see lots of support requests in GH/Discourse :P

@darrenjacoby
Copy link
Author

@runofthemill yea, good idea, I'll add an updating to 2.0.x section on the readme tomorrow.

@sagalbot
Copy link

Are there tasks remaining to get this out and tagged into a release?

@MWDelaney MWDelaney requested review from retlehs and QWp6t August 10, 2018 16:05
@MWDelaney
Copy link
Member

Are we not bringing in Controller 2.0.1 for a reason at this point?

@darrenjacoby
Copy link
Author

darrenjacoby commented Aug 10, 2018

I think there may be some hesitancy based on 2.0.1 because of the change to PSR4 Loading? I've since added "upgrading to 2.x.x" information to the docs. If we are updating, which I would recommend, I'd like to tag a new release which has been tested on dev-master for a while now. It'll address some existing issues on 2.0.1, happy to update this PR to reflect the new release.

@darrenjacoby darrenjacoby changed the title PSR4 loading for Controller 2.0.0 PSR4 loading for Controller 2.1.0 Aug 17, 2018
@darrenjacoby
Copy link
Author

Tagged the new release and updated the composer.json file here. Changelog can be found here, https://github.com/soberwp/controller/blob/master/CHANGELOG.md

@darrenjacoby darrenjacoby changed the title PSR4 loading for Controller 2.1.0 Upgrade to Controller 2.1.0 Aug 17, 2018
@retlehs retlehs merged commit 907825e into roots:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants