Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request validation and signature macros are missing #409

Open
stefanfisk opened this issue Oct 25, 2024 · 2 comments
Open

Request validation and signature macros are missing #409

stefanfisk opened this issue Oct 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@stefanfisk
Copy link
Contributor

Version

4.2.2

What did you expect to happen?

I expected the request validation and signature macros to be added.

What actually happens?

They are not.

I think that we need just need to copy FoundationServiceProvider::registerRequestValidation() and FoundationServiceProvider::registerRequestSignatureValidation().

AFAICT the functions work as expected as long as the macros are added.

Steps to reproduce

Try calling $request->validate().

System info

No response

Log output

No response

Please confirm this isn't a support request.

Yes

@stefanfisk stefanfisk added the bug Something isn't working label Oct 25, 2024
@stefanfisk
Copy link
Contributor Author

I can create a PR. Should they go in AcornServiceProvider?

@QWp6t
Copy link
Member

QWp6t commented Oct 25, 2024

Yeah, that would be awesome. Thanks @stefanfisk 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants