[cling-cpt] Added some more fixes to the download_llvm_binary function [skip-ci] #11098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
vgvassilev
reviewed
Aug 3, 2022
| download_link = 'http://releases.llvm.org/5.0.2/clang+llvm-5.0.2-x86_64-linux-gnu-ubuntu-16.04.tar.xz' | ||
| if DIST == "Ubuntu" and REV == '20.04' and is_os_64bit(): | ||
| download_link = 'https://github.com/llvm/llvm-project/releases/download/llvmorg-13.0.0/clang+llvm-13.0.0-x86_64-linux-gnu-ubuntu-20.04.tar.xz' | ||
| exec_subprocess_call('wget %s' % download_link, workdir) |
There was a problem hiding this comment.
Didn't we replace the subprocess calls to the proper wget analog in python? Can that be moved to it as well?
There was a problem hiding this comment.
@vgvassilev Yeah just fixed it thank you
saisoma123
force-pushed
the
llvmdownloadfix
branch
from
c9717ab
to
6bc54b5
Compare
|
Can you rebase this PR the commits seem odd. |
saisoma123
force-pushed
the
llvmdownloadfix
branch
from
3ce9c56
to
9978c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Improves the download_llvm_binary function
Changes or fixes: Added LLVM 13 support, fixed the binary flags, and fixed the llvm_config_path and llvm_dir
Checklist:
This PR fixes #406 mentioned in meta issue list (root-project/cling#406)