[cling-cpt] Added build option for the platform tags to the argument parser [skip-ci] #11020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for this branch. This commit adds build options for the platform tags.
|
Can one of the admins verify this patch? |
vgvassilev
reviewed
Jul 24, 2022
| @@ -2375,7 +2383,8 @@ def custom_input(prompt, always_yes=False): | |||
| tarball() | |||
| cleanup() | |||
|
|
|||
| if args['tarball_tag']: | |||
| if bool(args['tarball_tag']) ^ bool(args['tarball_tag_build']): | |||
There was a problem hiding this comment.
I wanted to use an exclusive or so that two of the options couldn't be called at the same time
There was a problem hiding this comment.
I would prefer to use or and make this check before we even come here. We can check and diagnose this condition where the user will know what they did wrong…
There was a problem hiding this comment.
Hi @vgvassilev just added the changes like you said
I also changed the xor to or now.
|
This pull request introduces 4 alerts and fixes 10 when merging 609e0e3 into f110cf6 - view on LGTM.com new alerts:
fixed alerts:
|
vgvassilev
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request: Adds another build option for building Cling with specific platform tags.
Changes or fixes: Added build options for the platform tags to the argument parser, then added additional if statements for checking whether the user wants to package it or not.
Checklist:
This PR fixes #406 mentioned in (root-project/cling#406)