Added new starting point for cpt.py- Cling Packaging Tool [skip-ci] #10728
Conversation
|
Can one of the admins verify this patch? |
Axel-Naumann
requested review from
vgvassilev
and removed request for
Axel-Naumann
Axel-Naumann
changed the title
| @@ -1834,7 +1834,8 @@ def custom_input(prompt, always_yes=False): | |||
| # Global variables # | |||
| ############################################################################### | |||
|
|
|||
| workdir = os.path.abspath(os.path.expanduser(args['with_workdir'])) | |||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
Can you clarify (in the commit message) what this change does and why it is needed?
There was a problem hiding this comment.
Hi @vgvassilev, I just made changes to the original commit message
There was a problem hiding this comment.
Can you format your commit message according to https://cbea.ms/git-commit/
There was a problem hiding this comment.
Yep just reformatted according to the link @vgvassilev, sorry for the wait
There was a problem hiding this comment.
I still see the old commit message style.
There was a problem hiding this comment.
Sorry not getting the notifications for this PR for some reason
There was a problem hiding this comment.
Hi @vgvassilev, commit style fixed sorry for the wait
Added new main block because this was mentioned in the meta issue list (root-project#406 in cling) as one of the rewrite steps. This also allows for the main code to be run as opposed to running the main code plus the function defintions.
This Pull request:
Adds a new starting point for cpt.py
Changes or fixes:
Added if name == "main" block to cpt.py
Checklist:
This PR fixes 406 (root-project/cling#406)