Skip to content

Commit 81559f5

Browse files
committed
[rootest] use override syntax for classes in io/newstl
1 parent 068987e commit 81559f5

File tree

6 files changed

+73
-72
lines changed

6 files changed

+73
-72
lines changed
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1+
#ifndef Test_hh
2+
#define Test_hh
3+
14
#include "TObject.h"
25
#include <complex>
36
#include <vector>
47

5-
#ifndef Test_hh
6-
#define Test_hh
7-
88
class Test: public TObject
99
{
1010
public:
11-
11+
1212
std::complex<double> fMyComplexVector;
1313
//std::vector<std::complex<double> > fMyComplexVector;
1414

1515
void Set(int seed) {
1616
fMyComplexVector = std::complex<double>(seed,seed*2);
1717
}
18-
18+
1919
bool TestValue(int seed) {
2020
return ( seed == (int)fMyComplexVector.real() && seed == (int)(fMyComplexVector.imag()/2) );
2121
}
22-
23-
ClassDef(Test, 1);
22+
23+
ClassDefOverride(Test, 1);
2424
};
2525
#endif /* Test_hh */

roottest/root/io/newstl/TestHelpers.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ bool IsEquiv(float orig, float copy) {
1515
bool IsEquiv(double orig, double copy) {
1616
double epsilon = 1e-14;
1717
double diff = orig-copy;
18-
// std::cerr << "epsilon = " << epsilon
19-
// << " diff = " << diff
18+
// std::cerr << "epsilon = " << epsilon
19+
// << " diff = " << diff
2020
// << " div = " << diff/copy
2121
// << " abs = " << TMath::Abs( diff/copy )
2222
// << " bool = " << (TMath::Abs( diff/copy ) < epsilon) << std::endl;
@@ -39,7 +39,7 @@ class nonvirtHelper {
3939
class Helper {
4040
public:
4141
unsigned int val;
42-
double dval;
42+
double dval;
4343
Helper() : val(0),dval(0) {}
4444
explicit Helper(int v,double d) : val(v),dval(d) {}
4545
virtual ~Helper() {};
@@ -71,8 +71,8 @@ class HelperDerived : public HelperClassDef {
7171
float f;
7272
HelperDerived() : f(-1) {};
7373
explicit HelperDerived(int v,double d, float finput) : HelperClassDef(v,d),f(finput) {};
74-
75-
virtual bool IsEquiv(const Helper &rhs) const {
74+
75+
virtual bool IsEquiv(const Helper &rhs) const {
7676
bool result = Helper::IsEquiv(rhs);
7777
if (result) {
7878
const HelperDerived *drhs = dynamic_cast<const HelperDerived*>(&rhs);
@@ -92,7 +92,7 @@ class HelperDerived : public HelperClassDef {
9292
return Form("HelperDerived object wrote %d %g %f and read %d %g %f\n",val,dval,f,drhs->val,drhs->dval,drhs->f);
9393
}
9494

95-
ClassDef(HelperDerived,1);
95+
ClassDefOverride(HelperDerived,1);
9696
};
9797

9898
class THelper : public Helper, public TObject {
@@ -104,16 +104,16 @@ class THelper : public Helper, public TObject {
104104
if (copy==0) return "Wrong type (expected THelper)\n";
105105
return Form("THelper object wrote %d %g and read %d %g\n",val,dval,copy->val,copy->dval);
106106
}
107-
ClassDef(THelper,1);
107+
ClassDefOverride(THelper,1);
108108
};
109109

110110
class THelperDerived : public THelper {
111111
public:
112112
float f;
113113
THelperDerived() : f(-1) {};
114114
explicit THelperDerived(int v,double d, float finput) : THelper(v,d),f(finput) {};
115-
116-
virtual bool IsEquiv(const Helper &rhs) const {
115+
116+
virtual bool IsEquiv(const Helper &rhs) const {
117117
bool result = Helper::IsEquiv(rhs);
118118
if (result) {
119119
const THelperDerived *drhs = dynamic_cast<const THelperDerived*>(&rhs);
@@ -133,7 +133,7 @@ class THelperDerived : public THelper {
133133
return Form("THelperDerived object wrote %d %g %f and read %d %g %f\n",val,dval,f,drhs->val,drhs->dval,drhs->f);
134134
}
135135

136-
ClassDef(THelperDerived,1);
136+
ClassDefOverride(THelperDerived,1);
137137
};
138138

139139
template <class T> class GHelper {

roottest/root/io/newstl/contHolder.h

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#include "TestSetOrVerify.h"
1818

1919
class TEST_CONT_HOLDER : public TObject {
20-
public:
20+
public:
2121

2222
TEST_CONT_HOLDER() : TObject()
2323
,fScalarArrVar(0)
@@ -45,7 +45,7 @@ class TEST_CONT_HOLDER : public TObject {
4545
for(int index=0;index<4;index++) fScalarPtrArr[index]=0;
4646
Reset(entry);
4747
}
48-
48+
4949
TEST_CONT<EHelper > fEnum;
5050

5151

@@ -58,9 +58,9 @@ class TEST_CONT_HOLDER : public TObject {
5858
TEST_CONT<std::pair<float,int> > fPairFlInt;
5959
TEST_CONT<std::pair<std::string,double> > fPairStrDb;
6060

61-
TEST_CONT<GHelper<GHelper<GHelper<float> > > > fTemplates;
61+
TEST_CONT<GHelper<GHelper<GHelper<float> > > > fTemplates;
6262
#endif
63-
63+
6464
UInt_t fScalarArrVarSize;
6565
TEST_CONT<char > *fScalarArrVar; //[fScalarArrVarSize]
6666

@@ -73,7 +73,7 @@ class TEST_CONT_HOLDER : public TObject {
7373
TEST_CONT<double > *fScalarPtrArr[4];
7474
UInt_t fScalarPtrArrVarSize;
7575
TEST_CONT<int > *fScalarPtrArrVar; //[fScalarPtrArrVarSize]
76-
76+
7777

7878
#if defined(R__CANNOT_SPLIT_STL_CONTAINER)
7979
TEST_CONT<Helper > fObject; //||
@@ -126,7 +126,7 @@ class TEST_CONT_HOLDER : public TObject {
126126
TEST_CONT<HelperClassDef*> fPtrHelperDerived; //!
127127
#else
128128
TEST_CONT<THelper*> fPtrTHelperDerived;
129-
TEST_CONT<HelperClassDef*> fPtrHelperDerived;
129+
TEST_CONT<HelperClassDef*> fPtrHelperDerived;
130130
#endif
131131

132132
#if defined(R__NO_NESTED_CONTAINER)
@@ -148,40 +148,40 @@ class TEST_CONT_HOLDER : public TObject {
148148
return utility::SetOrVerify("fEnum",fEnum,seed,entryNumber,reset,testname);
149149
}
150150
VERIFY(Enum);
151-
151+
152152

153153
bool SetOrVerifyTemplates(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
154154
Int_t seed = 1 * (entryNumber+1);
155155
return utility::SetOrVerify("fTemplates",fTemplates,seed,entryNumber,reset,testname);
156156
}
157157
VERIFY(Templates);
158-
158+
159159

160160
bool SetOrVerifyPairFlInt(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
161161
Int_t seed = 1 * (entryNumber+1);
162162
return utility::SetOrVerify("fPairFlInt",fPairFlInt,seed,entryNumber,reset,testname);
163163
}
164164
VERIFY(PairFlInt);
165-
165+
166166
bool SetOrVerifyPairStrDb(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
167167
Int_t seed = 1 * (entryNumber+1);
168168
return utility::SetOrVerify("fPairStrDb",fPairStrDb,seed,entryNumber,reset,testname);
169169
}
170170
VERIFY(PairStrDb);
171-
171+
172172

173173
bool SetOrVerifyBool(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
174174
Int_t seed = 1 * (entryNumber+1);
175175
return utility::SetOrVerify("fBool",fBool,seed,entryNumber,reset,testname);
176176
}
177177
VERIFY(Bool);
178-
178+
179179
bool SetOrVerifyScalar(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
180180
Int_t seed = 1 * (entryNumber+1);
181181
return utility::SetOrVerify("fScalar",fScalar,seed,entryNumber,reset,testname);
182182
}
183183
VERIFY(Scalar);
184-
184+
185185
bool SetOrVerifyScalarArr(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
186186
Int_t seed = 2 * (entryNumber+1);
187187
return utility::SetOrVerify("fScalarArr",&(fScalarArr[0]), 2 ,seed,entryNumber,reset,testname);
@@ -191,7 +191,7 @@ class TEST_CONT_HOLDER : public TObject {
191191
bool SetOrVerifyScalarArrVar(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
192192
if (!reset && gFile && !HasVarArrayOfContainers(gFile)) {
193193
return true;
194-
}
194+
}
195195
Int_t seed = 3 * (entryNumber+1);
196196
return utility::SetOrVerifyArrVar("fScalarArrVar",fScalarArrVar,fScalarArrVarSize,seed,entryNumber,reset,testname);
197197
}
@@ -213,7 +213,7 @@ class TEST_CONT_HOLDER : public TObject {
213213
bool SetOrVerifyScalarPtrArrVar(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
214214
if (!reset && gFile && !HasVarArrayOfContainers(gFile)) {
215215
return true;
216-
}
216+
}
217217
Int_t seed = 6 * (entryNumber+1);
218218
return utility::SetOrVerifyArrVar("fScalarPtrArrVar",fScalarPtrArrVar,fScalarPtrArrVarSize,seed,entryNumber,reset,testname);
219219
}
@@ -482,22 +482,22 @@ class TEST_CONT_HOLDER : public TObject {
482482
}
483483

484484
public:
485-
485+
486486
void Reset(Int_t entryNumber) {
487487
SetOrVerify(entryNumber, true, "reseting", 0);
488488
}
489-
489+
490490
bool Verify(Int_t entryNumber, const std::string &testname, int splitlevel) {
491491
return SetOrVerify(entryNumber,false,testname,splitlevel);
492492
}
493493

494494
#if defined(R__NO_NESTED_CONTAINER)
495-
ClassDef(TEST_CONT_HOLDER,1);
496-
#else
495+
ClassDefOverride(TEST_CONT_HOLDER,1);
496+
#else
497497
#if defined(R__NO_POLYMORPH_CLASSDEF_NONTOBJECT)
498-
ClassDef(TEST_CONT_HOLDER,2);
498+
ClassDefOverride(TEST_CONT_HOLDER,2);
499499
#else
500-
ClassDef(TEST_CONT_HOLDER,3);
500+
ClassDefOverride(TEST_CONT_HOLDER,3);
501501
#endif
502502
#endif
503503
};

roottest/root/io/newstl/gmapHolder.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
class TEST_MAP_HOLDER : public TObject {
1919

20-
public:
20+
public:
2121

2222
TEST_MAP_HOLDER() : TObject()
2323
,fScalarArrVar(0)
@@ -45,12 +45,12 @@ class TEST_MAP_HOLDER : public TObject {
4545
for(int index=0;index<4;index++) fScalarPtrArr[index]=0;
4646
Reset(entry);
4747
}
48-
48+
4949
std::TEST_MAP<EHelper, int > fEnumInt;
5050
std::TEST_MAP<std::string, EHelper > fStrEnum;
5151

5252
std::TEST_MAP<float, bool > fScalar;
53-
53+
5454
std::TEST_MAP<short, char > fScalarArr[2];
5555
UInt_t fScalarArrVarSize;
5656
std::TEST_MAP<char, short > *fScalarArrVar; //[fScalarArrVarSize]
@@ -59,7 +59,7 @@ class TEST_MAP_HOLDER : public TObject {
5959
std::TEST_MAP<double, float > *fScalarPtrArr[4];
6060
UInt_t fScalarPtrArrVarSize;
6161
std::TEST_MAP<int,double > *fScalarPtrArrVar; //[fScalarPtrArrVarSize]
62-
62+
6363

6464
std::TEST_MAP<Helper, Helper > fObject;
6565
std::TEST_MAP<Helper, Helper*> *fObjectPtr;
@@ -121,19 +121,19 @@ class TEST_MAP_HOLDER : public TObject {
121121
return utility::SetOrVerify("fEnumInt",fEnumInt,seed,entryNumber,reset,testname);
122122
}
123123
VERIFY(EnumInt);
124-
124+
125125
bool SetOrVerifyStrEnum(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
126126
Int_t seed = 1 * (entryNumber+1);
127127
return utility::SetOrVerify("fStrEnum",fStrEnum,seed,entryNumber,reset,testname);
128128
}
129129
VERIFY(StrEnum);
130-
130+
131131
bool SetOrVerifyScalar(Int_t entryNumber, bool reset, const std::string &testname,int /*splitlevel*/) {
132132
Int_t seed = 1 * (entryNumber+1);
133133
return utility::SetOrVerify("fScalar",fScalar,seed,entryNumber,reset,testname);
134134
}
135135
VERIFY(Scalar);
136-
136+
137137
bool SetOrVerifyScalarArr(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
138138
Int_t seed = 2 * (entryNumber+1);
139139
return utility::SetOrVerify("fScalarArr",&(fScalarArr[0]), 2 ,seed,entryNumber,reset,testname);
@@ -143,7 +143,7 @@ class TEST_MAP_HOLDER : public TObject {
143143
bool SetOrVerifyScalarArrVar(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
144144
if (!reset && gFile && !HasVarArrayOfContainers(gFile)) {
145145
return true;
146-
}
146+
}
147147
Int_t seed = 3 * (entryNumber+1);
148148
return utility::SetOrVerifyArrVar("fScalarArrVar",fScalarArrVar,fScalarArrVarSize,seed,entryNumber,reset,testname);
149149
}
@@ -168,7 +168,7 @@ class TEST_MAP_HOLDER : public TObject {
168168
bool SetOrVerifyScalarPtrArrVar(Int_t entryNumber, bool reset, const std::string &testname, int /*splitlevel*/) {
169169
if (!reset && gFile && !HasVarArrayOfContainers(gFile)) {
170170
return true;
171-
}
171+
}
172172
Int_t seed = 6 * (entryNumber+1);
173173
return utility::SetOrVerifyArrVar("fScalarPtrArrVar",fScalarPtrArrVar,fScalarPtrArrVarSize,seed,entryNumber,reset,testname);
174174
}
@@ -402,19 +402,19 @@ class TEST_MAP_HOLDER : public TObject {
402402
}
403403

404404
public:
405-
405+
406406
void Reset(Int_t entryNumber) {
407407
SetOrVerify(entryNumber, true, "reseting", 0);
408408
}
409-
409+
410410
bool Verify(Int_t entryNumber, const std::string &testname, int splitlevel) {
411411
return SetOrVerify(entryNumber,false,testname,splitlevel);
412412
}
413413

414414
#if defined(R__NO_NESTED_CONTAINER)
415-
ClassDef(TEST_MAP_HOLDER,1);
416-
#else
417-
ClassDef(TEST_MAP_HOLDER,2);
415+
ClassDefOverride(TEST_MAP_HOLDER,1);
416+
#else
417+
ClassDefOverride(TEST_MAP_HOLDER,2);
418418
#endif
419419
};
420420

0 commit comments

Comments
 (0)