Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-names tag does not work with default_icons #17

Closed
gschievelbein opened this issue Feb 1, 2021 · 4 comments
Closed

No-names tag does not work with default_icons #17

gschievelbein opened this issue Feb 1, 2021 · 4 comments

Comments

@gschievelbein
Copy link

When no-names is set to true, the names of applications that use the default_icon are still shown

@roosta
Copy link
Owner

roosta commented Feb 1, 2021

Hi, thank you for reporting. There was a decision made in a previous pull request, that it doesn't make that much sense to hide the name when default icon is enabled, how would you tell apart applications?

If this is a problem for you I'll patch it, but out of curiosity whats the use-case here?
EDIT: spelling

@gschievelbein
Copy link
Author

Hi. The main issue is that some applications have really long names that take almost half of the bar. When multiple applications without custom icons are open, the polybar i3 module pushes other modules out of view.

I also think that it does not make much sense to hide the name of some applications but not of others. I use the icons so that a quick glance at the corner of my screen is enough to know what I have open in each workspace. That is not possible if some application display their titles.

I set up custom icons to common applications that are always open. The default icon would be enough to find out in which workspace the other applications are.

@roosta
Copy link
Owner

roosta commented Feb 2, 2021

Thanks for the explanation, makes sense. I pushed a fix under the hotfix branch, would you mind trying it out before I draft a new version?

@gschievelbein
Copy link
Author

Thank you. It seems to be working fine with no issues so far.

@roosta roosta closed this as completed in 23ace5c Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants