Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MixedRouteQuoterV1 #8

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

thaixuandang
Copy link
Collaborator

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@thaixuandang thaixuandang changed the title Feature/mixed route quoter feat: add MixedRouteQuoterV1 Jul 25, 2024
@thaixuandang thaixuandang changed the base branch from release/v1.0.0 to feature/proxy July 29, 2024 10:47

// returns sorted token addresses, used to handle return values from pairs sorted in this order
function sortTokens(address tokenA, address tokenB) internal pure returns (address token0, address token1) {
require(tokenA != tokenB);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log error

function sortTokens(address tokenA, address tokenB) internal pure returns (address token0, address token1) {
require(tokenA != tokenB);
(token0, token1) = tokenA < tokenB ? (tokenA, tokenB) : (tokenB, tokenA);
require(token0 != address(0));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log error

Base automatically changed from feature/proxy to release/v1.0.0 August 26, 2024 08:34
@thaixuandang thaixuandang merged commit e04a962 into release/v1.0.0 Aug 26, 2024
2 checks passed
@thaixuandang thaixuandang deleted the feature/mixed-route-quoter branch August 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants