feat: proxy for KatanaV3Factory and NonfungiblePositionManager #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaixuandang
changed the title
…CODE_POINTER can be verified on sourcify
nxqbao
approved these changes
Jul 29, 2024
TuDo1403
reviewed
Aug 2, 2024
TuDo1403
reviewed
Aug 2, 2024
TuDo1403
reviewed
Aug 2, 2024
TuDo1403
reviewed
Aug 2, 2024
| treasury = _treasury; | ||
| emit TreasuryChanged(address(0), _treasury); | ||
| function initialize(address owner_, address treasury_) external { | ||
| require(!_initialized); |
TuDo1403
reviewed
Aug 2, 2024
TuDo1403
requested changes
Aug 2, 2024
| emit OwnerChanged(address(0), _owner); | ||
| constructor() { | ||
| // disable initialization | ||
| _initialized = true; |
There was a problem hiding this comment.
can we not used Initializable extension?
| function initializeImmutables(address factory_, address token0_, address token1_, uint24 fee_, int24 tickSpacing_) | ||
| public | ||
| override | ||
| { | ||
| require(!_immutablesInitialized); |
| @@ -125,8 +125,10 @@ contract KatanaV3Pool is IKatanaV3Pool { | |||
| _immutablesInitialized = true; | |||
TuDo1403
requested changes
Aug 2, 2024
| emit OwnerChanged(address(0), _owner); | ||
| constructor() { | ||
| // disable initialization | ||
| _initialized = true; |
There was a problem hiding this comment.
can we not used Initializable extension?
There was a problem hiding this comment.
please add gap and disable initializer
TuDo1403
requested changes
Aug 6, 2024
…proxy chore(`proxy`): merge from `release/v1.0.0`
thaixuandang
changed the base branch from
feature/flash-loans
to
release/v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist