feat: refactor #13
Merged
feat: refactor #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaixuandang
force-pushed
the
feat/refactor
branch
2 times, most recently
from
d95b6d9
to
e3e0ee2
Compare
TuDo1403
requested changes
Aug 25, 2024
|
I advise removing payable modifiers from functions since some peripheral contract use multi-delegate call. |
3 tasks
thaixuandang
force-pushed
the
feat/refactor
branch
from
fb49cca
to
11ec2c0
Compare
thaixuandang
force-pushed
the
feat/refactor
branch
from
11ec2c0
to
a9196ef
Compare
thaixuandang
force-pushed
the
feat/refactor
branch
from
c93d56b
to
b841b15
Compare
…ble with Uniswap tests
v3.4.1-solc-0.7-2
…ve sufficient balance after the callback
TuDo1403
reviewed
Aug 29, 2024
…l-known tokens on the Ronin network
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
reviewed
Sep 17, 2024
TuDo1403
approved these changes
Sep 18, 2024
khangvv
reviewed
Sep 19, 2024
| (token0, token1, fee, tickSpacing) = (token0_, token1_, fee_, tickSpacing_); | ||
| // cache these immutable addresses for gas savings when swaps, mints, or burns are performed | ||
| governance = IKatanaV3Factory(factory_).owner(); | ||
| positionManager = IKatanaGovernance(governance).getPositionManager(); |
There was a problem hiding this comment.
(Risk) Potential async risk when changing Governance or Position Manager address
Changing the governance or positionManager address in the factory (since it is upgradable) introduces a risk. It may break contract assumptions, affecting governance minting, swapping, and flash functionalities. If this occurs, the upgrade would also require updates to all active pools.
This known risk is documented here for future reference and should be formally addressed in documentation to prevent mistakes in future operations.
khangvv
reviewed
Sep 19, 2024
| @@ -749,6 +734,11 @@ contract KatanaV3Pool is IKatanaV3Pool { | |||
| require(balance1Before.add(uint256(amount1)) <= balance1(), "IIA"); | |||
| } | |||
|
|
|||
| // transfer protocol fees to the treasury | |||
| if (state.protocolFee > 0) { | |||
| TransferHelper.safeTransfer(tokenIn, IKatanaV3Factory(factory).treasury(), state.protocolFee); | |||
There was a problem hiding this comment.
should it also emit Collect event here or a new type of event (optional) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist