Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*BridgeManager): enhance manager with loose and executor #20

Merged
merged 15 commits into from
Apr 4, 2024

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Apr 1, 2024

Description

  • loose proposal: not revert the whole proposal if exists one failed internal call. Default value: false.
  • executor: only specified executor can execute and relay an approved proposal. Defaule value: address(0), which allow everyone to execute.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao changed the title Feat/enhance manager with loose and executer feat(*BridgeManager): enhance manager with loose and executer Apr 1, 2024
@nxqbao nxqbao marked this pull request as ready for review April 2, 2024 04:02
@nxqbao
Copy link
Contributor Author

nxqbao commented Apr 2, 2024

Need test for propose mainchain and relay mainchain

@nxqbao nxqbao changed the title feat(*BridgeManager): enhance manager with loose and executer feat(*BridgeManager): enhance manager with loose and executor Apr 2, 2024
@nxqbao nxqbao requested a review from TuDo1403 April 2, 2024 06:52
@nxqbao nxqbao force-pushed the feat/enhance-manager-with-loose-and-executer branch from f6f7899 to 143705d Compare April 2, 2024 07:45
src/libraries/Proposal.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will test hash later

@nxqbao nxqbao merged commit 320eb89 into release/v3.1.0 Apr 4, 2024
@nxqbao nxqbao deleted the feat/enhance-manager-with-loose-and-executer branch April 4, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants