-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle vote on bulk deposit for #2
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
test/bridge/integration/bridge-manager/deposit-and-record/bulkDepositAndRecord.Gateway.t.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.19; | ||
|
|
||
| import { console2 as console } from "forge-std/console2.sol"; | ||
| import { Transfer } from "@ronin/contracts/libraries/Transfer.sol"; | ||
| import { Token } from "@ronin/contracts/libraries/Token.sol"; | ||
| import "../../BaseIntegration.t.sol"; | ||
|
|
||
| contract BulkDepositAndRecord_Gateway_Test is BaseIntegration_Test { | ||
| using Transfer for Transfer.Receipt; | ||
|
|
||
| address _newBridgeOperator; | ||
| uint256 _numOperatorsForVoteExecuted; | ||
| Transfer.Receipt _sampleReceipt; | ||
| Transfer.Receipt[] _bulkReceipts; | ||
| uint256 _id = 0; | ||
|
|
||
| function setUp() public virtual override { | ||
| super.setUp(); | ||
|
|
||
| vm.deal(address(_bridgeReward), 10 ether); | ||
| _sampleReceipt = Transfer.Receipt({ | ||
| id: 0, | ||
| kind: Transfer.Kind.Deposit, | ||
| ronin: Token.Owner({ addr: makeAddr("recipient"), tokenAddr: address(_roninWeth), chainId: block.chainid }), | ||
| mainchain: Token.Owner({ addr: makeAddr("requester"), tokenAddr: address(_mainchainWeth), chainId: block.chainid }), | ||
| info: Token.Info({ erc: Token.Standard.ERC20, id: 0, quantity: 100 }) | ||
| }); | ||
|
|
||
| _numOperatorsForVoteExecuted = | ||
| _param.roninBridgeManager.bridgeOperators.length * _param.roninBridgeManager.num / _param.roninBridgeManager.denom; | ||
| } | ||
|
|
||
| function test_bulkDepositFor_wrapUp_checkRewardAndSlash() public { | ||
| _depositFor(); | ||
| _moveToEndPeriodAndWrapUpEpoch(); | ||
|
|
||
| console.log("=============== First 50 Receipts ==========="); | ||
| _bulkDepositFor(); | ||
|
|
||
| _wrapUpEpoch(); | ||
| _wrapUpEpoch(); | ||
|
|
||
| _moveToEndPeriodAndWrapUpEpoch(); | ||
|
|
||
| console.log("=============== Check slash and reward behavior ==========="); | ||
| console.log("==== Check total ballot before new deposit ===="); | ||
|
|
||
| logBridgeTracking(); | ||
|
|
||
| uint256 lastSyncedPeriod = uint256(vm.load(address(_bridgeTracking), bytes32(uint256(11)))); | ||
| for (uint256 i; i < _numOperatorsForVoteExecuted; i++) { | ||
| address operator = _param.roninBridgeManager.bridgeOperators[i]; | ||
| assertEq(_bridgeTracking.totalBallotOf(lastSyncedPeriod, operator), _id); | ||
| } | ||
|
|
||
| for (uint256 i = _numOperatorsForVoteExecuted; i < _param.roninBridgeManager.bridgeOperators.length; i++) { | ||
| address operator = _param.roninBridgeManager.bridgeOperators[i]; | ||
| assertEq(_bridgeTracking.totalBallotOf(lastSyncedPeriod, operator), 0); | ||
| } | ||
|
|
||
| console.log("==== Check total ballot after new deposit ===="); | ||
| _depositFor(); | ||
|
|
||
| logBridgeTracking(); | ||
| logBridgeSlash(); | ||
|
|
||
| lastSyncedPeriod = uint256(vm.load(address(_bridgeTracking), bytes32(uint256(11)))); | ||
| for (uint256 i; i < _param.roninBridgeManager.bridgeOperators.length; i++) { | ||
| address operator = _param.roninBridgeManager.bridgeOperators[i]; | ||
| assertEq(_bridgeTracking.totalBallotOf(lastSyncedPeriod, operator), 0); | ||
| } | ||
|
|
||
| uint256[] memory toPeriodSlashArr = _bridgeSlash.getSlashUntilPeriodOf(_param.roninBridgeManager.bridgeOperators); | ||
| for (uint256 i = _numOperatorsForVoteExecuted; i < _param.roninBridgeManager.bridgeOperators.length; i++) { | ||
| assertEq(toPeriodSlashArr[i], 7); | ||
| } | ||
| } | ||
|
|
||
| function _depositFor() internal { | ||
| console.log(">> depositFor ...."); | ||
| _sampleReceipt.id = ++_id; | ||
| for (uint256 i; i < _numOperatorsForVoteExecuted; i++) { | ||
| console.log(" -> Operator vote:", _param.roninBridgeManager.bridgeOperators[i]); | ||
| vm.prank(_param.roninBridgeManager.bridgeOperators[i]); | ||
| _roninGatewayV3.depositFor(_sampleReceipt); | ||
| } | ||
| } | ||
|
|
||
| function _bulkDepositFor() internal { | ||
| console.log(">> bulkDepositFor ...."); | ||
| _prepareBulkRequest(); | ||
| for (uint256 i; i < _numOperatorsForVoteExecuted; i++) { | ||
| console.log(" -> Operator vote:", _param.roninBridgeManager.bridgeOperators[i]); | ||
| vm.prank(_param.roninBridgeManager.bridgeOperators[i]); | ||
| _roninGatewayV3.tryBulkDepositFor(_bulkReceipts); | ||
| } | ||
| } | ||
|
|
||
| function _prepareBulkRequest() internal { | ||
| delete _bulkReceipts; | ||
|
|
||
| for (uint256 i; i < 50; i++) { | ||
| _sampleReceipt.id = ++_id; | ||
| _bulkReceipts.push(_sampleReceipt); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.