fix: handle vote on bulk deposit for #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxqbao
force-pushed
the
fix/handle-vote-on-bulkDepositFor
branch
from
21e226c
to
ba7c838
Compare
huyhuynh3103
reviewed
Mar 6, 2024
Comment on lines
+193
to
+197
| _executedReceipts = new bool[](receipts.length); | ||
| uint256 minVoteWeight = minimumVoteWeight(); | ||
|
|
||
| Transfer.Receipt memory iReceipt; | ||
| for (uint i; i < receipts.length; ++i) { |
There was a problem hiding this comment.
Suggested change
| _executedReceipts = new bool[](receipts.length); | |
| uint256 minVoteWeight = minimumVoteWeight(); | |
| Transfer.Receipt memory iReceipt; | |
| for (uint i; i < receipts.length; ++i) { | |
| uint256 length = receipts.length; | |
| _executedReceipts = new bool[](length); | |
| uint256 minVoteWeight = minimumVoteWeight(); | |
| Transfer.Receipt memory iReceipt; | |
| for (uint i; i < length; ++i) { |
huyhuynh3103
reviewed
Mar 6, 2024
Co-authored-by: HuyHuynh <[email protected]> Signed-off-by: Bao <[email protected]>
nxqbao
force-pushed
the
fix/handle-vote-on-bulkDepositFor
branch
from
bac2f15
to
1274c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.notion.so/skymavis/Bridge-Issues-7fb1ed7fbfbb45f6a5bf54451f2fe07f?pvs=4#aaf4801dc1fe4a38b38000087504c3eb
Checklist