Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support erc1155. Impl Batcher for supporting erc721/erc1155 in batch #16

Merged
merged 33 commits into from
Apr 11, 2024

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Mar 18, 2024

Description

Side Batcher for handle batcher request

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

request.info.handleAssetIn(msg.sender, request.tokenAddr, fHandleAssetIn);

// Approve all tokens from this Batcher to the actual Gateway
IERC721(request.tokenAddr).setApprovalForAll(address(_mainchainGateway), true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this share same interface with IERC1155, please rewrite for clarity

nxqbao and others added 2 commits April 1, 2024 18:30
Co-authored-by: tu-do.ron <[email protected]>
Signed-off-by: Bao <[email protected]>
@nxqbao nxqbao marked this pull request as ready for review April 8, 2024 06:44
@nxqbao nxqbao merged commit 0138197 into release/v3.2.0 Apr 11, 2024
@nxqbao nxqbao deleted the feat/support-ERC1155--batcher branch April 11, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants