🐛 Diagnostics don't inherit file path when creating a Location type

[ematipico]

Environment information

main

What happened?

At the moment there's a small issue where creating a Location via the builder pattern doesn't always pick up the file path injected via with_file_path.

This forces us, as a workaround, to do this: https://github.com/rome/tools/blob/main/crates/rome_analyze/src/diagnostics.rs#L114-L117

As a consequence, there's some code that is not called at the moment: https://github.com/rome/tools/blob/main/crates/rome_analyze/src/rule.rs#L394-L415

Expected result

We should be able to create a correct Location by mixing the location information coming from a client and the information inside a diagnostic type.

Code of Conduct

• I agree to follow Rome's Code of Conduct