Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 noRenderReturnValue incorrectly flags non React render calls #3617

Closed
1 task done
MichaReiser opened this issue Nov 9, 2022 · 0 comments · Fixed by #3626
Closed
1 task done

🐛 noRenderReturnValue incorrectly flags non React render calls #3617

MichaReiser opened this issue Nov 9, 2022 · 0 comments · Fixed by #3626
Assignees
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone

Comments

@MichaReiser
Copy link
Contributor

Environment information

Rome v10

What happened?

Rome incorrectly flags the use of the result of the following render call

function render(value) {
  return `Rendered: ${value}`
}

function test() {
  const result = render(a);
  
}

Playground

Expected result

Rome should only flag render calls that resolve to React's render function.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug good first issue Good for newcomers A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Nov 9, 2022
@leops leops self-assigned this Nov 9, 2022
@leops leops added this to the 10.0.1 milestone Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
2 participants