Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

☂️ Formatter 0.10.0 #3047

Closed
8 of 9 tasks
MichaReiser opened this issue Aug 11, 2022 · 7 comments
Closed
8 of 9 tasks

☂️ Formatter 0.10.0 #3047

MichaReiser opened this issue Aug 11, 2022 · 7 comments
Assignees
Labels
A-Formatter Area: formatter umbrella Issue to track a collection of other issues
Milestone

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Aug 11, 2022

Description

Goals

Tasks

Comments (~2 weeks)

  • Pre-process AST and extract comments
  • Improve comments placement

Prettier Compatibility (~1 week)

High Priority

Bugs

Best Effort

@MichaReiser MichaReiser added the umbrella Issue to track a collection of other issues label Aug 11, 2022
@MichaReiser MichaReiser added this to the 0.10.0 milestone Aug 11, 2022
@MichaReiser MichaReiser self-assigned this Aug 11, 2022
@denbezrukov
Copy link
Contributor

@MichaReiser MichaReiser added the A-Formatter Area: formatter label Sep 5, 2022
@MichaReiser
Copy link
Contributor Author

MichaReiser commented Sep 5, 2022

@MichaReiser Hi! I can try to help you with TS Intersection.

prettier/prettier@68bd87b/src/language-js/print/type-annotation.js#L94-L120

Whoops sorry. I missed this message. That would be awesome! Let me create an issue and assign that to you

Edit: I always forget that people have to comment first for me to be able to assign them o an issue. Would you mind commenting here: #3162

@nstepien
Copy link
Contributor

nstepien commented Sep 6, 2022

Really hoping for a trailing commas option, it's the biggest difference with Prettier for us. 🙏
https://prettier.io/docs/en/options.html#trailing-commas

@MichaReiser MichaReiser pinned this issue Sep 7, 2022
@cpojer
Copy link
Contributor

cpojer commented Sep 7, 2022

Here are a few more inconsistencies: #3178.

@MichaReiser
Copy link
Contributor Author

If anyone is interested having a look at the JSX spacing issues, let me know.

@MichaReiser
Copy link
Contributor Author

Really hoping for a trailing commas option, it's the biggest difference with Prettier for us. pray prettier.io/docs/en/options.html#trailing-commas

We're considering adding the trailing-comma es5 option which is the default in Prettier today. Would this be sufficient for your use case or are you using none?

@nstepien
Copy link
Contributor

We use "trailingComma": "none"

@ematipico ematipico modified the milestones: 0.10.0, 10.0.0 Oct 3, 2022
@ematipico ematipico unpinned this issue Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter umbrella Issue to track a collection of other issues
Projects
None yet
Development

No branches or pull requests

5 participants